Read only mode use case in catalog app. #2803
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santosh-pingle
changed the title
Screen.Recording.2025-03-12.at.3.19.01.PM.mov |
jingtang10
reviewed
Mar 12, 2025
| @@ -146,6 +146,14 @@ class DemoQuestionnaireFragment : Fragment() { | |||
| .LOCATION_WIDGET_PROVIDER, | |||
| ) | |||
| setQuestionnaire(args.questionnaireJsonStringKey!!) | |||
| when (args.layoutMode) { | |||
There was a problem hiding this comment.
can you please explore using a lambda to encapsulate these configurations? i think we might have more complex setups for different modes in the future and it's not ideal to have to change the demo questionnaire fragment class each time.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2804
Description
Add read only mode use case to the catalog app.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.