Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metalava upgrade #979

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Metalava upgrade #979

merged 3 commits into from
Feb 3, 2023

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Feb 3, 2023 •
edited
Loading

WHAT

Metalava upgrade

WHY

General health and tylerbwong/metalava-gradle#61

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke requested a review from luizgrp February 3, 2023 08:44
luizgrp
luizgrp approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@luizgrp luizgrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I think all the files from the auth modules will have to be regenerated

@yschimke yschimke marked this pull request as draft February 3, 2023 09:28
@yschimke yschimke marked this pull request as ready for review February 3, 2023 09:44
@yschimke yschimke merged commit 7ac32d8 into google:main Feb 3, 2023
@bentrengrove bentrengrove mentioned this pull request Feb 20, 2023
Merged
kul3r4 pushed a commit to kul3r4/horologist-1 that referenced this pull request Mar 1, 2023
@yschimke @kul3r4
Metalava upgrade (google#979)
7bb1804
@yschimke yschimke deleted the metalava branch April 17, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizgrp luizgrp luizgrp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yschimke @luizgrp