feat: add support for ordering in QueryRecords #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuryu
reviewed
May 31, 2022
api/open_saves.proto
Outdated
| } | ||
|
|
||
| // Property name to order by. | ||
| string property_name = 1; |
There was a problem hiding this comment.
not a request but will we allow sorting by system properties (like updated_at or blob_size)? In that case using oneof might make sense here (although we only have property_name right now).
There was a problem hiding this comment.
@loranger2k @labheshd what do you think? Is there a request to sort by these fields?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feat
What this PR does / Why we need it:
Adds the ability to query records and return them in a sorted order, given that the proper composite index is created.
Which issue(s) this PR fixes:
Closes #337
Special notes for your reviewer: