runner: support shell parameter #28
Conversation
|
Doc is missing though. If you are happy with the changes, I can then add the doc. |
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
========================================
Coverage ? 93.3%
========================================
Files ? 7
Lines ? 224
Branches ? 0
========================================
Hits ? 209
Misses ? 7
Partials ? 8
Continue to review full report at Codecov.
|
|
Interesting option 😃 However, I think running Orbit as mentioned in my comment on issue #27 should be the actual way of doing that. Still, an interesting option... |
app/runner/runner.go
Outdated
| @@ -46,6 +47,10 @@ type ( | |||
| // printing the available tasks. | |||
| Private bool `yaml:"private,omitempty"` | |||
|
|
|||
| // Shell allows to choose which binary will | |||
| // be called to run the commands | |||
There was a problem hiding this comment.
Point required at the end of the sentence #grammarNazi
app/runner/runner_test.go
Outdated
| t.Error("Custom shell task should have failed!") | ||
| } | ||
|
|
||
| // case 5: uses custom shell with existent shell. |
| if task.Shell != "" { | ||
| shellAndParams := strings.Fields(task.Shell) | ||
| shell := shellAndParams[0] | ||
| parameters := append(shellAndParams[1:], cmd) |
There was a problem hiding this comment.
I think we should check the numbers of field (if == 1, this won't work)
There was a problem hiding this comment.
Not sure about that: ariane test works correctly, right?
- You can now pass a shell parameter to your run task - support multiple words commands, such as `bash -c` - added failing an successful tests
|
🎉 ! |
Summary
This PR allows the user to choose a shell to run the task.
shellsupport single or multiple commands to run the shell:Run using bash:
This PR implements the following feature:
runexpected shell #27Fixes #27
Checklist
orbit run fmt)?orbit run ci)?