Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the possibility to call others tasks from a task #32

Merged
merged 1 commit into from
Apr 30, 2018
Merged

Conversation

gulien
Copy link
Owner

@gulien gulien commented Apr 30, 2018

This PR enable calling others tasks from a task within the same context.

orbit.yml:

tasks:
  - use: app
  - run:
      - {{ run "render" "upload" }}
      - echo "done!"

  - use: render
  - run:
      - cmd

  - use: upload
  - run:
      - cmd

Fixes #24

@gulien gulien added this to the v3.1.0 milestone Apr 30, 2018
@gulien
Copy link
Owner Author

gulien commented Apr 30, 2018

@j-vizcaino this solution is ok for your issue? 😄

@codecov
Copy link

codecov bot commented Apr 30, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@e8ee541). Click here to learn what that means.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #32   +/-   ##
=========================================
  Coverage          ?   92.56%           
=========================================
  Files             ?        7           
  Lines             ?      242           
  Branches          ?        0           
=========================================
  Hits              ?      224           
  Misses            ?       10           
  Partials          ?        8
Impacted Files Coverage Δ
app/generator/funcmap.go 75% <100%> (ø)
app/generator/generator.go 90.24% <100%> (ø)
app/runner/runner.go 94.36% <88.57%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8ee541...8bfcacf. Read the comment docs.

@gulien gulien mentioned this pull request Apr 30, 2018
4 tasks
gulien added a commit that referenced this pull request Apr 30, 2018
@j-vizcaino
Copy link
Contributor

Yes, this looks really good! Thank you very much!
I will give this a try and let you know if this works for my use-case.

Copy link
Contributor

@j-vizcaino j-vizcaino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly!
Thanks! 👍

@gulien
Copy link
Owner Author

gulien commented Apr 30, 2018

Great! Thank you for the feedback :)

@gulien gulien merged commit dfc5298 into master Apr 30, 2018
@gulien gulien deleted the subtask branch May 1, 2018 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants