Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: uploads using form-data do not honour per-chart-limit setting #1050

Open
alexberry opened this issue Feb 14, 2025 · 0 comments · May be fixed by #1051
Open

Bug: uploads using form-data do not honour per-chart-limit setting #1050

alexberry opened this issue Feb 14, 2025 · 0 comments · May be fixed by #1051
Assignees

Comments

@alexberry
Copy link

In #466 , support for per-chart limits was added, however during testing I found a bug.

There are two methods to upload a file to chartmuseum - one using binary data, the other using forms data. We upload our charts using the helm cm-push plugin, and it uses forms data to upload.

The forms data upload code path has not been updated to clean up like it has in the binary code path.

@alexberry alexberry linked a pull request Feb 14, 2025 that will close this issue
alexberry added a commit to alexberry/chartmuseum that referenced this issue Feb 14, 2025
* Ensure uploads using form-data utilise server.PutWithLimit
* Add tests
* Fixes helm#1050
alexberry added a commit to alexberry/chartmuseum that referenced this issue Feb 14, 2025
* Ensure uploads using form-data utilise server.PutWithLimit
* Add tests
* Fixes helm#1050

Signed-off-by: alexberry <[email protected]>
@scbizu scbizu self-assigned this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants