Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per chart limit option #466

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Add per chart limit option #466

merged 2 commits into from
Jan 28, 2022

Conversation

scbizu
Copy link
Contributor

@scbizu scbizu commented Jun 14, 2021

impls #316

Also , closes #376

  • backend storage and index cache supports per chart limit

Maybe in next release:

  • lock chart to be unremovable
  • provide a dry run command to clean museum(per chart) , also works with chart lock mechanism

@scbizu scbizu force-pushed the feature/per-chart-limit-option branch 13 times, most recently from 48ecd5b to 60ad56a Compare June 14, 2021 18:09
@scbizu
Copy link
Contributor Author

scbizu commented Jun 14, 2021

I found a problem during implementing this feature , dose all of our storage impls support the same name file covering. With the #454 , we can now update our cache index in the chart updating case , but it still can be stored into backend storage if this backend storage do not support the same name file covering or add some other more suffixes into the package name .

However, we maybe break the above case and the per-chart-limit option will also limit the same name artifact at N versions . I do not know if this should be mentioned in the next release note.

@scbizu scbizu self-assigned this Jun 14, 2021
@scbizu scbizu added this to the v0.14.0 milestone Jun 14, 2021
@scbizu scbizu marked this pull request as draft June 14, 2021 18:53
@scbizu scbizu marked this pull request as ready for review June 14, 2021 18:56
@scbizu scbizu requested a review from jdolitsky June 14, 2021 18:56
@jdolitsky
Copy link
Contributor

@scbizu - where do we stand with this and #457 ?

@scbizu
Copy link
Contributor Author

scbizu commented Jan 24, 2022

#376

@jdolitsky
Copy link
Contributor

@scbizu can you rebase?

@scbizu scbizu force-pushed the feature/per-chart-limit-option branch from 60ad56a to 84c9823 Compare January 28, 2022 16:29
@scbizu
Copy link
Contributor Author

scbizu commented Jan 28, 2022

done @jdolitsky

@jdolitsky jdolitsky merged commit b0326d6 into main Jan 28, 2022
@jdolitsky jdolitsky deleted the feature/per-chart-limit-option branch January 28, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a way to limit number of old charts?
3 participants