Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default connectTimeout in defaultHttpClient #876

Merged
merged 2 commits into from
May 21, 2023
Merged

Set default connectTimeout in defaultHttpClient #876

merged 2 commits into from
May 21, 2023

Conversation

armanbilge
Copy link
Member

Addresses #874 (comment), h/t @hnaderi.

amesgen
amesgen approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we could also adapt the docs of simple to mention this (and maybe also the already existing Java 11 TLS 1.3 workaround), as it currently still states "A Client wrapping the default HttpClient."

@amesgen amesgen mentioned this pull request May 21, 2023
Merged
@amesgen amesgen merged commit e778cd0 into series/0.9 May 21, 2023
@amesgen amesgen deleted the pr/connect-timeout branch May 21, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amesgen amesgen amesgen approved these changes

Assignees
No one assigned
Labels
core docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armanbilge @amesgen