-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide annotations that are outside of assignment page range #5937
Comments
A complication with this is that annotations created on EPUB-based books do not currently record page number selectors, so if the assignment range is expressed as a page range, rather than a CFI range, we cannot filter annotations against it them. Some things we can do:
|
Support `page:{number}` or `page:{start}-{end}` filters in the sidebar. When the query is a number, it must match the page label exactly. When it is a range, it matches the page number if: - The start and end of the range, and page number, are all numeric - The page number is between the parsed `start` and `end` points, inclusive Part of #5937.
Support `page:{number}` or `page:{start}-{end}` filters in the sidebar. When the query is a number, it must match the page label exactly. When it is a range, it matches the page number if: - The start and end of the range, and page number, are all numeric - The page number is between the parsed `start` and `end` points, inclusive Part of #5937.
Support `page:{number}` or `page:{start}-{end}` filters in the sidebar. When the query is a number, it must match the page label exactly. When it is a range, it matches the page number if: - The start and end of the range, and page number, are all numeric - The page number is between the parsed `start` and `end` points, inclusive Part of #5937.
Support `page:{number}` or `page:{start}-{end}` filters in the sidebar. When the query is a number, it must match the page label exactly. When it is a range, it matches the page number if: - The start and end of the range, and page number, are all numeric - The page number is between the parsed `start` and `end` points, inclusive Part of #5937.
Support `page:{number}` or `page:{start}-{end}` filters in the sidebar. When the query is a number, it must match the page label exactly. When it is a range, it matches the page number if: - The start and end of the range, and page number, are all numeric - The page number is between the parsed `start` and `end` points, inclusive Part of #5937.
Support `page:{number}` or `page:{start}-{end}` filters in the sidebar. When the query is a number, it must match the page label exactly. When it is a range, it matches the page number if: - The start and end of the range, and page number, are all numeric - The page number is between the parsed `start` and `end` points, inclusive Part of #5937.
This will be basically working once hypothesis/lms#5930 lands, with UI improvements to follow (see #6006). |
I'm marking this as done. Making toggling the visibility of annotations outside the page range more usable is necessary though and is covered by #6006. |
When the user is in an LMS assignment with a configured page range, annotations from outside of that range should be hidden by default.
In the case where the same book is being reused for multiple assignments, this will avoid showing annotations from one assignment while viewing another.
This issue may become obsolete pending developments in a more general discussion about filtering annotations by assignment + document rather than just by document in the LMS context.
The text was updated successfully, but these errors were encountered: