-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show page numbers on annotation cards #5986
Comments
Capture the page number and label for PDF selections using the same `PageSelector` type that we use for selections in PDF-based VitalSource books. This has various uses, but one of the immediate ones is that it will allow us to do some testing of the VS page range behaviors with PDFs, which are more convenient to test with. Related to: - #5986. - #3720 (this proposes a more PDF-specific selector that would also capture the page region as a rect).
An alternative to showing the information on the card would be adding additional headings to the thread list. We currently have headings for chapters today, which are only used in VitalSource ebooks. We could add a second level for the page number. The downside is that adding this hierarchy in other contexts (eg. notebook / dashboard) could be complex, so we'd probably still want a way to include the info somewhere on the individual annotation. |
Capture the page number and label for PDF selections using the same `PageSelector` type that we use for selections in PDF-based VitalSource books. This has various uses, but one of the immediate ones is that it will allow us to do some testing of the VS page range behaviors with PDFs, which are more convenient to test with. Related to: - #5986. - #3720 (this proposes a more PDF-specific selector that would also capture the page region as a rect).
Display page numbers on annotation cards when: - The `page_numbers` feature flag is enabled AND - The annotation has a `PageSelector` selector. This applies to VitalSource books and PDFs. Part of #5986
Display page numbers on annotation cards when: - The `page_numbers` feature flag is enabled AND - The annotation has a `PageSelector` selector. This applies to VitalSource books and PDFs. Part of #5986
Display page numbers on annotation cards when: - The `page_numbers` feature flag is enabled AND - The annotation has a `PageSelector` selector. This applies to VitalSource books and PDFs. Part of #5986
Discussion about a wider release - https://hypothes-is.slack.com/archives/C2C2U40LW/p1702462198924979. |
This is now shipped. |
We are planning to offer the ability to filter annotations based on page number in VitalSource, and by default annotations outside the current assignment's page range will be hidden. See #5937.
In order for it to be clearer to the user why they are or are not seeing a particular annotation, it is becoming more important to show the page number on the annotation itself. More generally it would be nice to implement this for PDFs as well, though in order to do that we will need to start capturing page numbers on PDF annotations.
A constraint we will have to handle is that older annotations will not have page numbers available.
The text was updated successfully, but these errors were encountered: