-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should not return 416 for empty files when Range
includes 0
#9238
Comments
Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
Finally, remember to use https://discuss.ipfs.io if you just need general support. |
IMO This is an issue with go and null files should be 200 if the range start at 0 (because handling the range is more expensive that just giving me the file): golang/go#54794 I'll implement an override inside kubo while we wait to see how golang/go#54794 develop. |
Checklist
Installation method
ipfs-update or dist.ipfs.tech
Version
Description
@aschmahmann reported seeing this on our public gateway
It seems that the error is induced by us having enabled fragment caching and therefore adding a header
"Range: bytes=0-1048575"
to any requests that dont already have them (which is common practice)We can induce the behaviour locally with:
My reading of the spec, particularly
(if it means strictly greater than and not greater than or equal) is that was more correct to serve a 203 or maybe 200 there?
The text was updated successfully, but these errors were encountered: