Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gw): send 200 for empty files #9241

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Aug 31, 2022

Fixes #9238

@Jorropo Jorropo requested a review from lidel as a code owner August 31, 2022 16:26
@Jorropo Jorropo self-assigned this Aug 31, 2022
@Jorropo Jorropo force-pushed the fix/416-on-ranged-empty-files branch 2 times, most recently from 1ff8677 to eb71317 Compare August 31, 2022 16:28
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible, but please restore explicit content-type header (see below)

@Jorropo Jorropo force-pushed the fix/416-on-ranged-empty-files branch from eb71317 to 80c08ff Compare August 31, 2022 22:56
@Jorropo Jorropo enabled auto-merge (rebase) August 31, 2022 23:02
@Jorropo Jorropo merged commit df22205 into ipfs:master Aug 31, 2022
@Jorropo Jorropo deleted the fix/416-on-ranged-empty-files branch August 31, 2022 23:21
@Jorropo Jorropo restored the fix/416-on-ranged-empty-files branch December 12, 2022 22:32
@Jorropo Jorropo deleted the fix/416-on-ranged-empty-files branch December 12, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Should not return 416 for empty files when Range includes 0
2 participants