Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GRPC Client For Interacting With Remote Storage #6789

Open
mahadzaryab1 opened this issue Mar 2, 2025 · 0 comments
Open

Implement GRPC Client For Interacting With Remote Storage #6789

mahadzaryab1 opened this issue Mar 2, 2025 · 0 comments

Comments

@mahadzaryab1
Copy link
Collaborator

mahadzaryab1 commented Mar 2, 2025

As part of #6629, we defined the API for the v2 remote storage API. We now want to implement a client that will interact with that API.

@mahadzaryab1 mahadzaryab1 self-assigned this Mar 2, 2025
github-merge-queue bot pushed a commit that referenced this issue Mar 5, 2025
## Which problem is this PR solving?
- Towards #6789

## Description of the changes
- This PR moves the internal `TracesData` type to package `jptrace` so
that it can be used by the client for GRPC storage as well.

## How was this change tested?
- CI

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Mahad Zaryab <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Mar 9, 2025
…dependency_storage.proto` (#6819)

<!--
!! Please DELETE this comment before posting.
We appreciate your contribution to the Jaeger project! 👋🎉
-->

## Which problem is this PR solving?
- Towards #6789

## Description of the changes
- This PR removes the gogoproto annotations from `trace_storage.proto`
and `dependency_storage.proto` to avoid introducing a dependency on gogo
for users. Instead, it uses a similar patching mechanism to api_v3 to
add the annotations when generating the *.pb.go files.
 
## How was this change tested?
- CI

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Mahad Zaryab <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Mar 9, 2025
## Which problem is this PR solving?
- Towards #6789

## Description of the changes
- This PR addresses
#6829 (comment)
and changes the remote storage api v2 to return a chunk of traces
instead of a single trace from `GetTraces` and `FindTraces`

## How was this change tested?
- CI

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Mahad Zaryab <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Mar 11, 2025
…rage api v2 (#6829)

<!--
!! Please DELETE this comment before posting.
We appreciate your contribution to the Jaeger project! 👋🎉
-->

## Which problem is this PR solving?
- Towards #6789

## Description of the changes
- This PR implements a `TraceReader` for the remote storage API v2 along
with `GetServices` call.

## How was this change tested?
- Added a unit test

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Mahad Zaryab <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Mar 15, 2025
…torage api v2 (#6843)

<!--
!! Please DELETE this comment before posting.
We appreciate your contribution to the Jaeger project! 👋🎉
-->

## Which problem is this PR solving?
- Towards #6789

## Description of the changes
- This PR implements the `GetOperations` call in the gRPC tracereader

## How was this change tested?
- Added a unit test

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Mahad Zaryab <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant