Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grpc][v2] Implement GetOperations Call in gRPC reader for remote storage api v2 #6843

Merged
merged 5 commits into from
Mar 15, 2025

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

  • This PR implements the GetOperations call in the gRPC tracereader

How was this change tested?

  • Added a unit test

Checklist

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.06%. Comparing base (2ee205b) to head (804bada).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6843      +/-   ##
==========================================
- Coverage   96.07%   96.06%   -0.02%     
==========================================
  Files         367      368       +1     
  Lines       20787    20825      +38     
==========================================
+ Hits        19972    20005      +33     
- Misses        622      626       +4     
- Partials      193      194       +1     
Flag Coverage Δ
badger_v1 9.88% <ø> (+0.07%) ⬆️
badger_v2 2.05% <ø> (+0.07%) ⬆️
cassandra-4.x-v1-manual 14.87% <ø> (+0.06%) ⬆️
cassandra-4.x-v2-auto 2.04% <ø> (+0.07%) ⬆️
cassandra-4.x-v2-manual 2.04% <ø> (+0.07%) ⬆️
cassandra-5.x-v1-manual 14.87% <ø> (+0.06%) ⬆️
cassandra-5.x-v2-auto 2.04% <ø> (+0.07%) ⬆️
cassandra-5.x-v2-manual 2.04% <ø> (+0.07%) ⬆️
elasticsearch-6.x-v1 19.55% <ø> (+0.01%) ⬆️
elasticsearch-7.x-v1 19.62% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v1 19.79% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v2 2.16% <ø> (+0.18%) ⬆️
grpc_v1 10.92% <ø> (+0.06%) ⬆️
grpc_v2 7.98% <ø> (+0.07%) ⬆️
kafka-3.x-v1 10.18% <ø> (+0.07%) ⬆️
kafka-3.x-v2 2.05% <ø> (+0.07%) ⬆️
memory_v2 2.05% <ø> (+0.07%) ⬆️
opensearch-1.x-v1 19.67% <ø> (+0.01%) ⬆️
opensearch-2.x-v1 19.67% <ø> (+0.01%) ⬆️
opensearch-2.x-v2 2.05% <ø> (+0.07%) ⬆️
tailsampling-processor 0.55% <ø> (+0.07%) ⬆️
unittests 94.93% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
@mahadzaryab1 mahadzaryab1 enabled auto-merge March 15, 2025 00:03
@mahadzaryab1 mahadzaryab1 added this pull request to the merge queue Mar 15, 2025
Merged via the queue into jaegertracing:main with commit d6ac23c Mar 15, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants