[JENKINS-51818] Add JNLP port availability check #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (e instanceof SocketTimeoutException) { | ||
| reason = "timeout while attempting to reach node " + hostname + " on port " + port; | ||
| } | ||
| } finally { |
There was a problem hiding this comment.
maybe it makes sense to suppress other exceptions (runtime&Co)
|
@denami Would it be possible to create a JIRA ticket for this defect? |
denami
changed the title
denami
changed the title
|
Yes. JIRA ticket created. |
KostyaSha
approved these changes
Jun 12, 2018
KostyaSha
reviewed
Jun 12, 2018
| s = new Socket(); | ||
| s.setReuseAddress(true); | ||
| SocketAddress sa = new InetSocketAddress(hostname, port); | ||
| s.connect(sa, timeout); |
There was a problem hiding this comment.
probably `setSoTimeout()' for safety should be also defined
There was a problem hiding this comment.
connect() method also has simple check for timeout value.
There was a problem hiding this comment.
connect timeout != readtimeout , there is no read here, but just in case something will try to read from stream it may stuck operation
There was a problem hiding this comment.
In this case we read nothing from socket. I think it is not necessary.
|
@oleg-nenashev Is any restriction for merge this pull request? |
oleg-nenashev
approved these changes
Jun 21, 2018
dwnusbaum
approved these changes
Jun 21, 2018
|
Release ETA: tomorrow |
saptarshide007
pushed a commit
to saptarshide007/remoting
that referenced
this pull request
Mar 22, 2021
After updating from java 8 to java 11 getting the below error:- Exception in thread "main" java.lang.IllegalArgumentException: object is not an instance of declaring class at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at hudson.remoting.Launcher.addClasspath(Launcher.java:129) On analysing the remoting source code found that the hudson.remoting.Launcher.addClasspath invokes URLClassLoader and passes the instance using ClassLoader.getSystemClassLoader(). However in java 11, this seems like an illegal operation as ClassLoader.getSystemClassLoader() does not get the instance of URLClassLoader due to which we are getting the error "object is not an instance of declaring class". To fix this issue what updated the addClasspath method to invoke the URLClassLoader using a new instance of the class. Reference:- GitIssues:-jenkinsci#274,jenkinsci#275
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In same configuration of balancer or firewall Jenkins HTTP/HTTPS port available for slave, but JNLP port is not visible for slave.