[JENKINS-52204] - Skip port availability check when -tunnel option is set #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
approved these changes
Jun 28, 2018
There was a problem hiding this comment.
Looks good to me. It would be great to add a connection test using the tunnel option to have a chance of catching regressions like this, although I don't have a sense of how much work it would be to add such a test. Maybe it would require the Jenkins integration testing stuff you were working on earlier?
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the JENKINS-52204 regression in Remoting 3.22 and Jenkins 2.129. When
-tunneloption is set, Jenkins may be connecting to different host. So it does not make much sense to verify port availability in that case.The issue comes from #275 . Although I believe that the current
-tunnelbehavior is rather obsolete and should be reworked/removed (JENKINS-52246), I propose to just disable the check and restore compatibility for nowCC @denami @jeffret-b @dwnusbaum