Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application/importmap+json #267

Closed
wants to merge 1 commit into from
Closed

Add application/importmap+json #267

wants to merge 1 commit into from

Conversation

FlippieCoetser
Copy link

External Import maps require a specific MIME-type, here is the link to W3C and to WICG

@dougwilson
Copy link
Contributor

Awesome, thank you @FlippieCoetser ! The links you were provided where a bit unclear on the file extension, but since there is a repo for the spec, I asked for clarification at WICG/import-maps#282 . I'll merge it with an affirmative response, or if there is no response in a reasonable time frame since that one part does seem to imply that is the file extension.

@FlippieCoetser
Copy link
Author

FlippieCoetser commented Jul 4, 2022

@dougwilson I noticed you closed the PR, does this mean application/importmap+json will not be added? Section 2.3 and 6.1.1 in the W3C Spec mention the new MIME type. Without the new MIME type chrome browser does not accept the external importmap.

@dougwilson
Copy link
Contributor

Hi @FlippieCoetser I did not close the PR. The timeline shows it was closed after you posted your comment about it being closed. You can just reopen it. I'm just awaiting the info I asked for above to merge.

@dougwilson
Copy link
Contributor

It looks like your fork was deleted, which I guess github auto closed the pr due to that. It is unclear what closd the PR, because it is says closed (instead of by who like it normally does) and every time we post, it koves down, as if it was closed in the far future or something.

@FlippieCoetser
Copy link
Author

@dougwilson, there is no option to reopen the PR. very strange.

@dougwilson
Copy link
Contributor

Yea, I realized that in my second comment. You cannot reopen a pr if you deleted your fork. That is probably what closed it as well.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants