-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infra: Add gradle p.1 #783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi germanosin! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
Please update the dependabot configuration as well 🙏 See kafka-ui/.github/dependabot.yml Line 4 in ed49499
|
(cherry picked from commit 6cf3881)
(cherry picked from commit 4a6ee2b)
(cherry picked from commit 7c5fbd1)
(cherry picked from commit 112ede0)
Co-authored-by: Roman Zabaluev <[email protected]> (cherry picked from commit 8085237)
Co-authored-by: Roman Zabaluev <[email protected]> (cherry picked from commit 4f568c5)
(cherry picked from commit 17e0624)
(cherry picked from commit f828fd3)
<resources> | ||
<resource> | ||
<directory>../frontend/build</directory> | ||
<directory>../frontend/build/vite/static</directory> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this change and https://github.com/kafbat/kafka-ui/pull/783/files/4a0e1329e6ec4132ef5dc00e0ecdf8135836688f#diff-f35103f068e191d5d8933637b2d4217d8f90a78728ccab1bada951a8d1c83590R459, if you build the project as before using Maven and the command mvn clean install -Pprod -DskipTests
, then attempting to open the page in the browser will result in an error:
2025-03-09 06:35:37,493 ERROR [parallel-4] o.s.b.a.w.r.e.AbstractErrorWebExceptionHandler: [4a5b796b-1] 500 Server Error for HTTP GET "/"
2025-03-09T06:35:37.499916272Z java.io.FileNotFoundException: class path resource [static/index.html] cannot be opened because it does not exist
2025-03-09T06:35:37.499924293Z at org.springframework.core.io.ClassPathResource.getInputStream(ClassPathResource.java:215)
@Haarolean Could you please let me know if there are plans to support Maven builds during some transition period, or will the files related to Maven be removed in the near future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wernerdv gradle migration is complete though, you can achieve the same this way:
./gradlew clean build -x test -Pinclude-frontend=true -Pbuild-docker-images=true
The rest of maven-related files are to be removed. Let me know if you experience any issues with building via gradle.
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)