Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: Add gradle p.1 #783

Merged
merged 8 commits into from
Mar 8, 2025
Merged

Infra: Add gradle p.1 #783

merged 8 commits into from
Mar 8, 2025

Conversation

germanosin
Copy link
Member

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • [] Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@germanosin germanosin requested review from a team as code owners January 15, 2025 11:45
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jan 15, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi germanosin! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@Haarolean Haarolean requested a review from yeikel January 15, 2025 12:19
@Haarolean Haarolean added scope/backend Related to backend changes and removed status/triage/manual Manual triage in progress labels Jan 15, 2025
@Haarolean Haarolean linked an issue Jan 15, 2025 that may be closed by this pull request
6 tasks
@Haarolean Haarolean added the scope/infra CI, CD, dev. env, etc. label Jan 15, 2025
@Haarolean Haarolean changed the title Gradle Infra: Migrate to gradle Jan 15, 2025
@yeikel
Copy link
Collaborator

yeikel commented Jan 15, 2025

Please update the dependabot configuration as well 🙏

See

- package-ecosystem: maven

Haarolean

This comment was marked as resolved.

@Haarolean Haarolean self-requested a review January 17, 2025 11:01
@Haarolean Haarolean changed the title Infra: Migrate to gradle Infra: Migrate to gradle p.1 Jan 17, 2025
@Haarolean Haarolean changed the title Infra: Migrate to gradle p.1 Infra: Add gradle p.1 Jan 17, 2025
@Haarolean Haarolean mentioned this pull request Jan 17, 2025
6 tasks
@yeikel
Copy link
Collaborator

yeikel commented Feb 5, 2025

What's the status of this PR? I'd love an update given that it blocks #773

Can we merge #773 until this is completed? The conflict should be very minimal and easy to resolve anyways

@Haarolean
Copy link
Member

What's the status of this PR? I'd love an update given that it blocks #773

Can we merge #773 until this is completed? The conflict should be very minimal and easy to resolve anyways

This will take some time. Let's discuss this in #773

@Haarolean Haarolean requested a review from a team as a code owner March 2, 2025 16:38
(cherry picked from commit 6cf3881)
(cherry picked from commit 4a6ee2b)
(cherry picked from commit 7c5fbd1)
(cherry picked from commit 112ede0)
Co-authored-by: Roman Zabaluev <[email protected]>
(cherry picked from commit 8085237)
Co-authored-by: Roman Zabaluev <[email protected]>
(cherry picked from commit 4f568c5)
(cherry picked from commit 17e0624)
(cherry picked from commit f828fd3)
@Haarolean Haarolean self-assigned this Mar 8, 2025
@Haarolean Haarolean changed the base branch from main to gradle_final March 8, 2025 12:03
@Haarolean Haarolean merged commit d6f51e8 into gradle_final Mar 8, 2025
16 of 20 checks passed
@Haarolean Haarolean deleted the gradle branch March 8, 2025 12:04
@Haarolean Haarolean restored the gradle branch March 8, 2025 12:43
@Haarolean Haarolean deleted the gradle branch March 8, 2025 13:01
<resources>
<resource>
<directory>../frontend/build</directory>
<directory>../frontend/build/vite/static</directory>
Copy link
Contributor

@wernerdv wernerdv Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this change and https://github.com/kafbat/kafka-ui/pull/783/files/4a0e1329e6ec4132ef5dc00e0ecdf8135836688f#diff-f35103f068e191d5d8933637b2d4217d8f90a78728ccab1bada951a8d1c83590R459, if you build the project as before using Maven and the command mvn clean install -Pprod -DskipTests, then attempting to open the page in the browser will result in an error:

2025-03-09 06:35:37,493 ERROR [parallel-4] o.s.b.a.w.r.e.AbstractErrorWebExceptionHandler: [4a5b796b-1]  500 Server Error for HTTP GET "/"  
2025-03-09T06:35:37.499916272Z java.io.FileNotFoundException: class path resource [static/index.html] cannot be opened because it does not exist  
2025-03-09T06:35:37.499924293Z 	at org.springframework.core.io.ClassPathResource.getInputStream(ClassPathResource.java:215) 

@Haarolean Could you please let me know if there are plans to support Maven builds during some transition period, or will the files related to Maven be removed in the near future?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wernerdv gradle migration is complete though, you can achieve the same this way:

./gradlew clean build -x test -Pinclude-frontend=true -Pbuild-docker-images=true

The rest of maven-related files are to be removed. Let me know if you experience any issues with building via gradle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend Related to backend changes scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Gradle
4 participants