Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infra: Add gradle p.1 #783
Infra: Add gradle p.1 #783
Changes from all commits
6e4b3ec
b4e6cb0
e57268b
29b1cb0
505c719
1689458
6cf9492
4a0e132
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this change and https://github.com/kafbat/kafka-ui/pull/783/files/4a0e1329e6ec4132ef5dc00e0ecdf8135836688f#diff-f35103f068e191d5d8933637b2d4217d8f90a78728ccab1bada951a8d1c83590R459, if you build the project as before using Maven and the command
mvn clean install -Pprod -DskipTests
, then attempting to open the page in the browser will result in an error:@Haarolean Could you please let me know if there are plans to support Maven builds during some transition period, or will the files related to Maven be removed in the near future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wernerdv gradle migration is complete though, you can achieve the same this way:
The rest of maven-related files are to be removed. Let me know if you experience any issues with building via gradle.