-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTV-395: UI – Out of place image captions #1542
Conversation
…ous element caption text
Codecov Report
@@ Coverage Diff @@
## master #1542 +/- ##
=========================================
Coverage 68.93% 68.93%
Complexity 442 442
=========================================
Files 169 169
Lines 4301 4301
Branches 231 231
=========================================
Hits 2965 2965
Misses 1271 1271
Partials 65 65 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Liked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
…roid-oss into imartin/NTV-406-clean-up * 'imartin/NTV-406-clean-up' of github.com:kickstarter/android-oss: NTV-395: UI – Out of place image captions (#1542)
…tin/NTV-319-Substitute-BoolSharedPrefs-BoolDataStore * 'master' of github.com:kickstarter/android-oss: (60 commits) NTV-366: DiscoveryParams migrated to kotlin and deprecated autoparcel (#1554) NTV-383: Migrate Message.java to kotlin and deprecate Autoparcel (#1551) NTV-415 :Jacoco code coverage only looking throw Java classes (#1550) NTV-399 Reply comments created with invalid commentable (#1549) NTV-414: /v1/activities was called from the app several times #1548 NTV-412: Hide old campaign links #1547 NTV-364: Discovery Activity fetchCategories from GraphQL (#1546) NTV-410: Upgrade stripe SDK (#1544) NTV-406: Remove old ProjectActivity and clean feature flag (#1543) NTV-395: UI – Out of place image captions (#1542) NTV-397: Clickable images on campaign (#1541) NTV-350 :Add Save Project deep link (#1540) NTV-360: Zoom on campaign images (#1539) Fix friend avatar issue (#1538) NTV-349 Add Save Project button to cards on Discovery (#1537) NTV-372: Update braze/segment dependency to 10.0.0 (#1532) NTV-188: Project story (#1536) added percentage funded (#1535) NTV-365 Migrate to Kotlin `DiscoveryAdapter.java` (#1531) NTV-367: Discovery drawer adapter (#1530) ...
📲 What
🤔 Why
🛠 How
👀 See
BeforeBugCaption.mp4
BugCaption.mp4
| | |
📋 QA
Story 📖
NTV-395