Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-395: UI – Out of place image captions #1542

Merged
merged 3 commits into from
Feb 15, 2022
Merged

Conversation

Arkariang
Copy link
Contributor

📲 What

  • You could see captions on images where there were really not caption on the original HTMl, or even see them appear after scrolling up and down

🤔 Why

  • When the cell was recycled with a new Image element, the caption UI piece was not updated therefore showing caption data if the previous loaded image element had it.

🛠 How

  • Clear the caption text

👀 See

  • Before Video: You can see wild captions appear on images that should not have them
BeforeBugCaption.mp4
  • After Video: No wild captions anymore
BugCaption.mp4

| | |

📋 QA

  • Load this project and pay close attention to the caption on images, you can compare with the website to make sure no caption is visible out of place

Story 📖

NTV-395

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #1542 (36f8b9e) into master (2a47258) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1542   +/-   ##
=========================================
  Coverage     68.93%   68.93%           
  Complexity      442      442           
=========================================
  Files           169      169           
  Lines          4301     4301           
  Branches        231      231           
=========================================
  Hits           2965     2965           
  Misses         1271     1271           
  Partials         65       65           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a47258...36f8b9e. Read the comment docs.

@Arkariang Arkariang marked this pull request as ready for review February 15, 2022 00:09
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Liked

Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Arkariang Arkariang merged commit cf96299 into master Feb 15, 2022
@Arkariang Arkariang deleted the imartin/ntv-395 branch February 15, 2022 17:30
Arkariang added a commit that referenced this pull request Feb 16, 2022
…roid-oss into imartin/NTV-406-clean-up

* 'imartin/NTV-406-clean-up' of github.com:kickstarter/android-oss:
  NTV-395: UI – Out of place image captions (#1542)
Arkariang added a commit that referenced this pull request Mar 3, 2022
…tin/NTV-319-Substitute-BoolSharedPrefs-BoolDataStore

* 'master' of github.com:kickstarter/android-oss: (60 commits)
  NTV-366: DiscoveryParams migrated to kotlin and deprecated autoparcel (#1554)
  NTV-383: Migrate Message.java to kotlin and deprecate Autoparcel (#1551)
  NTV-415 :Jacoco code coverage only looking throw Java classes (#1550)
  NTV-399  Reply comments created with invalid commentable (#1549)
  NTV-414: /v1/activities was called from the app several times #1548
  NTV-412: Hide old campaign links #1547
  NTV-364: Discovery Activity fetchCategories from GraphQL (#1546)
  NTV-410: Upgrade stripe SDK (#1544)
  NTV-406: Remove old ProjectActivity and clean feature flag (#1543)
  NTV-395: UI – Out of place image captions (#1542)
  NTV-397: Clickable images on campaign (#1541)
  NTV-350 :Add Save Project deep link (#1540)
  NTV-360: Zoom on campaign images (#1539)
  Fix friend avatar issue (#1538)
  NTV-349  Add Save Project button to cards on Discovery (#1537)
  NTV-372: Update braze/segment dependency to 10.0.0 (#1532)
  NTV-188: Project story (#1536)
  added percentage funded (#1535)
  NTV-365  Migrate to Kotlin `DiscoveryAdapter.java` (#1531)
  NTV-367: Discovery drawer adapter (#1530)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants