Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-415 :Jacoco code coverage only looking throw Java classes #1550

Merged
merged 19 commits into from
Feb 28, 2022

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Feb 25, 2022

📲 What

  1. Figure out how to track Kotlin classes
  2. Make sure the Adapters are not tracked
  3. Make sure we track at least all the ViewModels. models, and kotlin extensions we have on Kotlin.

Story 📖

https://kickstarter.atlassian.net/browse/NTV-415

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #1550 (cafbf5f) into master (94934a9) will increase coverage by 10.35%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #1550       +/-   ##
=============================================
+ Coverage     65.71%   76.07%   +10.35%     
- Complexity      431     1483     +1052     
=============================================
  Files           163      355      +192     
  Lines          3824    14169    +10345     
  Branches        200     1568     +1368     
=============================================
+ Hits           2513    10779     +8266     
- Misses         1253     2581     +1328     
- Partials         58      809      +751     
Impacted Files Coverage Δ
...ava/com/kickstarter/ui/adapters/ThanksAdapter.java
...ckstarter/ui/adapters/CreatorDashboardAdapter.java
...kickstarter/ui/adapters/DiscoveryPagerAdapter.java
...i/adapters/ProjectNotificationSettingsAdapter.java
...i/adapters/CreatorDashboardRewardStatsAdapter.java
.../kickstarter/ui/adapters/ProjectSocialAdapter.java
...in/java/com/kickstarter/ui/adapters/KSAdapter.java
...adapters/CreatorDashboardReferrerStatsAdapter.java
...i/adapters/CreatorDashboardBottomSheetAdapter.java
...a/com/kickstarter/ui/adapters/MessagesAdapter.java
... and 208 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94934a9...cafbf5f. Read the comment docs.

@hadia hadia changed the title Fix JaCoCo NTV-415 :Jacoco code coverage only looking throw Java classes Feb 28, 2022
@hadia hadia marked this pull request as ready for review February 28, 2022 21:11
@hadia hadia merged commit a376990 into master Feb 28, 2022
@hadia hadia deleted the hadia/fix_JaCoCo branch February 28, 2022 22:01
Arkariang added a commit that referenced this pull request Feb 28, 2022
…tin/NTV-366-deprecate-autoparcel-discovery-params

* 'master' of github.com:kickstarter/android-oss:
  NTV-415 :Jacoco code coverage only looking throw Java classes (#1550)
  NTV-399  Reply comments created with invalid commentable (#1549)
  NTV-414: /v1/activities was called from the app several times #1548
Arkariang added a commit that referenced this pull request Mar 3, 2022
…tin/NTV-319-Substitute-BoolSharedPrefs-BoolDataStore

* 'master' of github.com:kickstarter/android-oss: (60 commits)
  NTV-366: DiscoveryParams migrated to kotlin and deprecated autoparcel (#1554)
  NTV-383: Migrate Message.java to kotlin and deprecate Autoparcel (#1551)
  NTV-415 :Jacoco code coverage only looking throw Java classes (#1550)
  NTV-399  Reply comments created with invalid commentable (#1549)
  NTV-414: /v1/activities was called from the app several times #1548
  NTV-412: Hide old campaign links #1547
  NTV-364: Discovery Activity fetchCategories from GraphQL (#1546)
  NTV-410: Upgrade stripe SDK (#1544)
  NTV-406: Remove old ProjectActivity and clean feature flag (#1543)
  NTV-395: UI – Out of place image captions (#1542)
  NTV-397: Clickable images on campaign (#1541)
  NTV-350 :Add Save Project deep link (#1540)
  NTV-360: Zoom on campaign images (#1539)
  Fix friend avatar issue (#1538)
  NTV-349  Add Save Project button to cards on Discovery (#1537)
  NTV-372: Update braze/segment dependency to 10.0.0 (#1532)
  NTV-188: Project story (#1536)
  added percentage funded (#1535)
  NTV-365  Migrate to Kotlin `DiscoveryAdapter.java` (#1531)
  NTV-367: Discovery drawer adapter (#1530)
  ...
Arkariang added a commit that referenced this pull request Mar 10, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss:
  NTV-410 && NTV-406: Bug fixing. (#1562)
  NTV-382: Migrate Activity.java to kotlin, deprecate autoparcel (#1559)
  WEB-361: Fix flaky date time test in RefTagUtils (#1561)
  NTV-423: bug fixing on Campaign tabg (#1560)
  NTV-361: Fix flaky tests related to datetime (#1558)
  Update comment counts to include replies (#1555)
  - revert back gradle version
  Migrate update.java to kotlin and deprecate AutoParcel (#1553)
  NTV-366: DiscoveryParams migrated to kotlin and deprecated autoparcel (#1554)
  NTV-383: Migrate Message.java to kotlin and deprecate Autoparcel (#1551)
  NTV-415 :Jacoco code coverage only looking throw Java classes (#1550)
  NTV-399  Reply comments created with invalid commentable (#1549)
  NTV-414: /v1/activities was called from the app several times #1548
  NTV-412: Hide old campaign links #1547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants