Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-jira]: Update gradle & kotlin #1556

Merged
merged 59 commits into from
May 30, 2022
Merged

[no-jira]: Update gradle & kotlin #1556

merged 59 commits into from
May 30, 2022

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Mar 3, 2022

📲 What

  • Update kotlin version
  • Update gradle plugin
  • Update some libraries

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #1556 (8c1e450) into master (52530b4) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1556      +/-   ##
============================================
- Coverage     78.38%   78.35%   -0.04%     
+ Complexity     1863     1862       -1     
============================================
  Files           353      353              
  Lines         16509    16509              
  Branches       2032     2031       -1     
============================================
- Hits          12941    12936       -5     
- Misses         2412     2413       +1     
- Partials       1156     1160       +4     
Impacted Files Coverage Δ
app/src/main/java/com/kickstarter/libs/Build.java 62.50% <0.00%> (-12.50%) ⬇️
...rc/main/java/com/kickstarter/ui/data/PledgeData.kt 91.17% <0.00%> (-2.95%) ⬇️
...om/kickstarter/libs/utils/extensions/ProjectExt.kt 72.15% <0.00%> (-2.54%) ⬇️
...va/com/kickstarter/libs/loadmore/ApolloPaginate.kt 70.37% <0.00%> (-0.93%) ⬇️
.../com/kickstarter/libs/utils/AnalyticEventsUtils.kt 72.68% <0.00%> (-0.52%) ⬇️
...src/main/java/com/kickstarter/models/StoredCard.kt 94.91% <0.00%> (ø)
...java/com/kickstarter/viewmodels/ThreadViewModel.kt 90.39% <0.00%> (ø)
...java/com/kickstarter/viewmodels/UpdateViewModel.kt 89.86% <0.00%> (ø)
...va/com/kickstarter/viewmodels/CommentsViewModel.kt 86.60% <0.00%> (ø)
...ckstarter/libs/utils/extensions/ConfigExtension.kt 56.75% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52530b4...8c1e450. Read the comment docs.

hadia and others added 27 commits March 3, 2022 22:17
- Remove the testCoverageEnabled line
@hadia hadia marked this pull request as ready for review May 26, 2022 19:18
@hadia hadia requested review from Arkariang and leighdouglas May 26, 2022 19:18
@hadia hadia force-pushed the upgrad_gradle_and_test_jacoco branch from 936dc9c to 2ce7251 Compare May 26, 2022 20:49
@Arkariang Arkariang changed the title Update gradle [no-jira]: Update gradle & kotlin May 30, 2022
@hadia hadia merged commit 2bb8949 into master May 30, 2022
@hadia hadia deleted the upgrad_gradle_and_test_jacoco branch May 30, 2022 22:03
Arkariang added a commit that referenced this pull request Jun 6, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss:
  versions and codes
  NTV-552 : Migrate BackingActivity ,BackingViewModel classes to kotlin (#1635)
  NTV-371 :  Migrate `DiscoveryPagerAdapter.java` (#1630)
  NTV 547 : Migrate key classes to kotlin (#1633)
  NTV-546   Migrate qualifiers package Interface to Kotlin (#1631)
  NTV-550: Creator facing crash (#1634)
  NTV-548: Unable to resolve host "api.kickstarter.com" (#1632)
  [no-jira]: Update gradle & kotlin  (#1556)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants