Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-371 : Migrate DiscoveryPagerAdapter.java #1630

Merged
merged 4 commits into from
Jun 3, 2022
Merged

NTV-371 : Migrate DiscoveryPagerAdapter.java #1630

merged 4 commits into from
Jun 3, 2022

Conversation

hadia
Copy link
Contributor

@hadia hadia commented May 26, 2022

📲 What

Migrate DiscoveryPagerAdapter.java

📋 QA

Make sure everything works as before

Story 📖

https://kickstarter.atlassian.net/browse/NTV-371

@hadia hadia added the migration Migration Java to Kotlin label May 26, 2022
@hadia hadia requested review from Arkariang and leighdouglas May 26, 2022 01:03
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #1630 (0e5bec4) into master (7979237) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1630   +/-   ##
=========================================
  Coverage     78.35%   78.35%           
  Complexity     1862     1862           
=========================================
  Files           353      353           
  Lines         16503    16503           
  Branches       2031     2031           
=========================================
  Hits          12931    12931           
  Misses         2412     2412           
  Partials       1160     1160           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7979237...0e5bec4. Read the comment docs.

@hadia hadia merged commit 2a8791f into master Jun 3, 2022
@hadia hadia deleted the hadia/NTV-371 branch June 3, 2022 18:24
Arkariang added a commit that referenced this pull request Jun 6, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss:
  versions and codes
  NTV-552 : Migrate BackingActivity ,BackingViewModel classes to kotlin (#1635)
  NTV-371 :  Migrate `DiscoveryPagerAdapter.java` (#1630)
  NTV 547 : Migrate key classes to kotlin (#1633)
  NTV-546   Migrate qualifiers package Interface to Kotlin (#1631)
  NTV-550: Creator facing crash (#1634)
  NTV-548: Unable to resolve host "api.kickstarter.com" (#1632)
  [no-jira]: Update gradle & kotlin  (#1556)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration Migration Java to Kotlin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants