Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAY-1445: Add ons local receipt UI #1621

Merged
merged 9 commits into from
May 4, 2022

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented May 3, 2022

📲 What

  • AddOn with local receipt UI
  • Added unit tests
  • Added screenshot test

🛠 How

  • Modified the AddOn reusable component to reflect the new local receipt information

👀 See

Screen Shot 2022-05-03 at 2 32 13 PM

AddOnsPledge.mp4

| | |

📋 QA

Story 📖

[Name of Trello Story](Trello link)

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #1621 (e07270e) into master (320b98f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1621   +/-   ##
=========================================
  Coverage     78.42%   78.42%           
  Complexity     1796     1796           
=========================================
  Files           354      354           
  Lines         15897    15897           
  Branches       1846     1846           
=========================================
  Hits          12467    12467           
  Misses         2440     2440           
  Partials        990      990           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 320b98f...e07270e. Read the comment docs.

@Arkariang Arkariang marked this pull request as ready for review May 3, 2022 21:38
@Arkariang Arkariang requested review from leighdouglas and hadia May 3, 2022 21:38
@Arkariang Arkariang changed the title Imartin/ntv 1445 add ons local receipt UI NTV-1445: Add ons local receipt UI May 3, 2022
@Arkariang Arkariang changed the title NTV-1445: Add ons local receipt UI PAY-1445: Add ons local receipt UI May 4, 2022
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉👌🏻

@Arkariang Arkariang merged commit d99859c into master May 4, 2022
@Arkariang Arkariang deleted the imartin/NTV-1445-AddOnsLocalReceiptUI branch May 4, 2022 20:00
Arkariang added a commit that referenced this pull request May 30, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss: (41 commits)
  [No-jira]: remove autoparcel dependencies (#1628)
  Update internal and external version coddes after release
  NTV-542: Update Exoplayer dependency to 2.17.1 (#1627)
  WEB-476 :open editorial Link to deep link android app not working (#1587)
  NTV-380  :Migrate Environment.java to kotlin and deprecate Autoparcel (#1626)
  NTV-483: Migrate ProjectStatsEnvelope.java to kotlin and deprecate Autoparcel (#1625)
  NTV-537: Update perimeterX (#1624)
  PAY-1587: Translations (#1623)
  NTV-480: Migrate InternalBuildEnvelope.java to kotlin and deprecate Autoparcel (#1612)
  NTV-483 :Migrate ProjectStatsEnvelope.java to kotlin and deprecate Autoparcel (#1622)
  PAY-1445: Add ons local receipt UI (#1621)
  NTV-535: Fix crashes (#1620)
  PAY-1441: Add ons for local pickup reward (#1619)
  NTV-479  :Migrate Activity.java Push model to kotlin and deprecate Autoparcel (#1618)
  PAY-1521: Pledge Screen show localReceiptLocation UI (#1617)
  NTV-486: Migrate StarEnvelope.java to kotlin and deprecate Autoparcel (#1615)
  [No-jira]: Update schema.json (#1616)
  PAY-1571: Rewards Carousel can display localReceiptLocation UI (#1614)
  PAY-1524: Added new feature flag + updated Schema.json (#1613)
  NTV-493: Deprecate Autoparcel for PledgeData.kt (#1611)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants