Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-483: Migrate ProjectStatsEnvelope.java to kotlin and deprecate Autoparcel #1625

Merged
merged 6 commits into from
May 17, 2022

Conversation

leighdouglas
Copy link
Contributor

📲 What

  • Converted ProjectStatsEnvelope.java and ProjectStatsEnvelopeFactory.java to kotlin
  • Deprecate Autoparcel for Parcelize
  • Tests

🤔 Why

Deprecation of autoparcel library in an ongoing effort to migrate to android's in-house parcelize.

👀 See

  • No user facing changes.

Story 📖

NTV-483: Migrate ProjectStatsEnvelope.java to kotlin and deprecate Autoparcel
WEB-457: Migrate ProjectStatsEnvelope.java to kotlin and deprecate Autoparcel

@leighdouglas leighdouglas requested review from Arkariang and hadia May 11, 2022 20:46
@leighdouglas leighdouglas added maintenance 🗜 migration Migration Java to Kotlin labels May 11, 2022
@leighdouglas leighdouglas force-pushed the leigh/ntv-483-projectstatsenvelop branch from 02cfb51 to 65f8c66 Compare May 16, 2022 16:10
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefect👌

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #1625 (65f8c66) into master (77360c1) will increase coverage by 0.00%.
The diff coverage is 83.51%.

@@            Coverage Diff             @@
##             master    #1625    +/-   ##
==========================================
  Coverage     78.65%   78.66%            
- Complexity     1832     1841     +9     
==========================================
  Files           354      354            
  Lines         16088    16370   +282     
  Branches       1877     1949    +72     
==========================================
+ Hits          12654    12877   +223     
  Misses         2419     2419            
- Partials       1015     1074    +59     
Impacted Files Coverage Δ
...rter/services/apiresponses/ProjectStatsEnvelope.kt 80.62% <80.62%> (ø)
...rter/mock/factories/ProjectStatsEnvelopeFactory.kt 100.00% <100.00%> (ø)
...main/java/com/kickstarter/models/ErroredBacking.kt 88.46% <0.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5eef0...65f8c66. Read the comment docs.

@leighdouglas leighdouglas merged commit fe584cc into master May 17, 2022
@leighdouglas leighdouglas deleted the leigh/ntv-483-projectstatsenvelop branch May 17, 2022 17:02
Arkariang added a commit that referenced this pull request May 30, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss: (41 commits)
  [No-jira]: remove autoparcel dependencies (#1628)
  Update internal and external version coddes after release
  NTV-542: Update Exoplayer dependency to 2.17.1 (#1627)
  WEB-476 :open editorial Link to deep link android app not working (#1587)
  NTV-380  :Migrate Environment.java to kotlin and deprecate Autoparcel (#1626)
  NTV-483: Migrate ProjectStatsEnvelope.java to kotlin and deprecate Autoparcel (#1625)
  NTV-537: Update perimeterX (#1624)
  PAY-1587: Translations (#1623)
  NTV-480: Migrate InternalBuildEnvelope.java to kotlin and deprecate Autoparcel (#1612)
  NTV-483 :Migrate ProjectStatsEnvelope.java to kotlin and deprecate Autoparcel (#1622)
  PAY-1445: Add ons local receipt UI (#1621)
  NTV-535: Fix crashes (#1620)
  PAY-1441: Add ons for local pickup reward (#1619)
  NTV-479  :Migrate Activity.java Push model to kotlin and deprecate Autoparcel (#1618)
  PAY-1521: Pledge Screen show localReceiptLocation UI (#1617)
  NTV-486: Migrate StarEnvelope.java to kotlin and deprecate Autoparcel (#1615)
  [No-jira]: Update schema.json (#1616)
  PAY-1571: Rewards Carousel can display localReceiptLocation UI (#1614)
  PAY-1524: Added new feature flag + updated Schema.json (#1613)
  NTV-493: Deprecate Autoparcel for PledgeData.kt (#1611)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance 🗜 migration Migration Java to Kotlin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants