PAY-1692: Shipping label when changing rewards to Local pickup reward #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1638 +/- ##
=========================================
Coverage 78.37% 78.38%
- Complexity 1861 1862 +1
=========================================
Files 353 353
Lines 16521 16521
Branches 2034 2034
=========================================
+ Hits 12949 12950 +1
Misses 2408 2408
+ Partials 1164 1163 -1
Continue to review full report at Codecov.
|
Arkariang
added a commit
that referenced
this pull request
Jun 15, 2022
…tin/new-architecture * 'master' of github.com:kickstarter/android-oss: NTV-556 : Migrate Creator Dashboard viewmodels classes to Kotlin (#1639) WEB-532 : [Android] Canceled backer: Remove "show comment" link from comment tombstones (#1641) [no-jira]: remove redundant observable subscription (#1640) PAY-1692: Shipping label when changing rewards to Local pickup reward (#1638)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Local rewards should not have a "shipping" line in the amounts summary section of the view pledge screen. If a backer goes from a shipping reward to a local receipt reward, the shipping line will still incorrectly appear with the prior selected shipping destination country and a shipping cost of $0.
Translation strings have been generated with errors, correct them from now until the
server-config.jsonis generated correctly.👀 See
| Before 🐛 |
|After 🦋 |
shipping_sumary_gone.mp4
| | |
📋 QA
Steps to reproduce:
1 - Pledge to a reward with shipping
2 - Change reward to a local pickup reward
3 - Open Manage pledge screen
Solved when: Shipping label is gone for local pickup rewards
Story 📖
PAY-1692