NTV-556 : Migrate Creator Dashboard viewmodels classes to Kotlin #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadia
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1639 +/- ##
============================================
+ Coverage 78.38% 78.42% +0.04%
+ Complexity 1862 1861 -1
============================================
Files 353 353
Lines 16521 16573 +52
Branches 2034 2039 +5
============================================
+ Hits 12950 12998 +48
+ Misses 2408 2406 -2
- Partials 1163 1169 +6
Continue to review full report at Codecov.
|
…ewmodels_classes_to_Kotlin
…ewmodels_classes_to_Kotlin
Arkariang
approved these changes
Jun 14, 2022
…ewmodels_classes_to_Kotlin
…shboard_viewmodels_classes_to_Kotlin' into hadia/NTV-556_Migrate_Creator_Dashboard_viewmodels_classes_to_Kotlin
hadia
deleted the
hadia/NTV-556_Migrate_Creator_Dashboard_viewmodels_classes_to_Kotlin
branch
Arkariang
added a commit
that referenced
this pull request
Jun 15, 2022
…tin/new-architecture * 'master' of github.com:kickstarter/android-oss: NTV-556 : Migrate Creator Dashboard viewmodels classes to Kotlin (#1639) WEB-532 : [Android] Canceled backer: Remove "show comment" link from comment tombstones (#1641) [no-jira]: remove redundant observable subscription (#1640) PAY-1692: Shipping label when changing rewards to Local pickup reward (#1638)
Arkariang
added a commit
that referenced
this pull request
Jul 6, 2022
…tin/PAY-1693-integrate-paymentsheet * 'master' of github.com:kickstarter/android-oss: WEB-605: Update string for flagged comments (#1650) NTV-563 : Migrate Message related viewmodels classes to Kotlin (#1649) WEB-567: Show flagged comment UI/state when pending T&S review (#1648) - Release 3.3.0 Comments from canceled backers with no replies do not appear in the list of comments (#1645) NTV-561: Update dependencies (#1646) WEB-566: [Android] UI for flagged comment (#1643) NTV-560: Updated gems (#1644) PAY-1716: Update stripe SDK (#1642) NTV-556 : Migrate Creator Dashboard viewmodels classes to Kotlin (#1639) WEB-532 : [Android] Canceled backer: Remove "show comment" link from comment tombstones (#1641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Migrate classes from java to kotlin
DashboardRewardStatsRowHolderViewModelCreatorDashboardReferrerBreakdownHolderViewModelCreatorDashboardReferrerStatsHolderViewModelCreatorDashboardReferrerStatsRowHolderViewModelCreatorDashboardRewardStatsHolderViewModelCreatorDashboardViewModel🤔 Why
Migrate All classes to java.
📋 QA
test Creator dashboard screen
Story 📖
https://kickstarter.atlassian.net/browse/NTV-556