This repository was archived by the owner on Nov 25, 2020. It is now read-only.
Fix for insertion new item before the last item #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -104,9 +104,9 @@ module.exports = class KDListView extends KDView | |||
| {boxed, lastToFirst} = @getOptions() | |||
|
|
|||
|
|
|||
| isLastIndex = index >= @items.length - 1 | |||
| isLastIndex = index > @items.length - 1 | |||
There was a problem hiding this comment.
Can you move cache the result of length - 1 and use that if possible, I know it was already like that but changing it to a local variable would be better for DRY.
|
Other than that minor stuff, it LGTM. Thanks for that @alex-ionochkin 👍 |
|
@usirin, thanks for review. I cached |
usirin
added a commit
that referenced
this pull request
Jan 26, 2015
…dex-fix Fix for insertion new item before the last item
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sinan, can you review this fix? It's for a case when new item should be inserted before the last item in the list. Currently new item is added to the end of the list in this case