Skip to content
This repository was archived by the owner on Nov 25, 2020. It is now read-only.

Fix for insertion new item before the last item #109

Merged
merged 2 commits into from
Jan 26, 2015
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/components/list/listview.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,10 @@ module.exports = class KDListView extends KDView
{boxed, lastToFirst} = @getOptions()


isLastIndex = index >= @items.length - 1
endIndex = @items.length - 1
isLastIndex = index > endIndex
isFirstIndex = index is 0
isInBetween = 0 < index < @items.length - 1
isInBetween = 0 < index <= endIndex

if isFirstIndex then @items.unshift item
else if isLastIndex then @items.push item
Expand All @@ -116,7 +117,8 @@ module.exports = class KDListView extends KDView

addNeighborItem = (item, index) =>
element = item.getElement()
neighborItem = @items[index + 1].getElement()
neighborIndex = if @items.length - 1 is index then index else index + 1
neighborItem = @items[neighborIndex].getElement()
neighborItem.parentNode.insertBefore element, neighborItem
item.emit 'viewAppended' if @parentIsInDom

Expand Down