-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ModelCache e2e test #4136
Merged
Merged
Add ModelCache e2e test #4136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe8e098
to
35bfe6f
Compare
yuzisun
reviewed
Dec 23, 2024
4ef2b0f
to
4860cd9
Compare
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
4860cd9
to
8fa3591
Compare
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
8fa3591
to
c91c5da
Compare
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
980fc9e
to
f592d36
Compare
/lgtm |
gavrissh
added a commit
to gavrissh/kserve
that referenced
this pull request
Jan 17, 2025
Signed-off-by: Gavrish Prabhu <[email protected]> fix formatting Signed-off-by: Gavrish Prabhu <[email protected]> add vllm to poetry Signed-off-by: Gavrish Prabhu <[email protected]> Add affinity and tolerations to localmodel daemonset (kserve#4173) * Add affinity and tolerations to localmodel daemonset Signed-off-by: Jin Dong <[email protected]> * make generate Signed-off-by: Jin Dong <[email protected]> --------- Signed-off-by: Jin Dong <[email protected]> Fix s3 download PermanentRedirectError for legacy s3 endpoint (kserve#4157) * sets virtual addressing style for legacy s3 endpoint Signed-off-by: bentohset <[email protected]> * add unit test Signed-off-by: bentohset <[email protected]> * fix formatting Signed-off-by: bentohset <[email protected]> * fix unit tests Signed-off-by: bentohset <[email protected]> --------- Signed-off-by: bentohset <[email protected]> Co-authored-by: Lize Cai <[email protected]> Make label and annotation propagation configurable (kserve#4030) * Make label and annotation propagation configurable chore: Make the DisallaowedAnnotations and Labels configurable through ConfigMap so users can configured it quickly. fixes kserve#3710 Signed-off-by: Spolti <[email protected]> * generate boilerplate code Signed-off-by: Spolti <[email protected]> * Edgar's review changes Signed-off-by: Spolti <[email protected]> --------- Signed-off-by: Spolti <[email protected]> Add ModelCache e2e test (kserve#4136) * Add client sdk for localmodelcache, localmodelnodegroup Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Add e2e test for modelcache Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Use docker driver and minikube tunnel Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Merge "Allow multiple node groups in the model cache CR (kserve#4134)" Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Try mounting image dir Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Add local model agent to image scan Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Debug Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Create model root directory beforehand Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Restart kserve controller after patch Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Enablepvc direct mount in e2e test Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Reduce pv storage to 1GB Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Update modelcache test Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Update status-check to include modelcache logs Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Update vllm to 0.6.6 (kserve#4176) Signed-off-by: Rajat Vig <[email protected]> Co-authored-by: Dan Sun <[email protected]> [bugfix] fix s3 storage download filename bug (kserve#4162) * [bugfix] fix s3 storage download filename bug - ensure correct path and file name preservation during s3 downloads in storage-initializer Signed-off-by: Jaeyeon Kim <[email protected]> * update lint - fix format Signed-off-by: Jaeyeon Kim <[email protected]> * fix format Signed-off-by: Jaeyeon Kim <[email protected]> --------- Signed-off-by: Jaeyeon Kim <[email protected]> update lint fix Signed-off-by: Gavrish Prabhu <[email protected]> update lint fix Signed-off-by: Gavrish Prabhu <[email protected]> update lint fix Signed-off-by: Gavrish Prabhu <[email protected]> openai model test Signed-off-by: Gavrish Prabhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3949
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note:
Re-running failed tests
/rerun-all
- rerun all failed workflows./rerun-workflow <workflow name>
- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.