feat: List.merge and lemmas
#579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgdorais
added
the
awaiting-review
kim-em
approved these changes
Feb 4, 2024
|
The |
Ruben-VandeVelde
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 12, 2024
Std has added a different definition with the same name in leanprover-community/batteries#579. It is easier to preemptively rename the version in mathlib.
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 13, 2024
This if @fgdorais's patch for leanprover-community/batteries#579. Co-authored-by: F. G. Dorais <[email protected]> Co-authored-by: Scott Morrison <[email protected]>
dagurtomas
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 22, 2024
This if @fgdorais's patch for leanprover-community/batteries#579. Co-authored-by: F. G. Dorais <[email protected]> Co-authored-by: Scott Morrison <[email protected]>
utensil
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 26, 2024
This if @fgdorais's patch for leanprover-community/batteries#579. Co-authored-by: F. G. Dorais <[email protected]> Co-authored-by: Scott Morrison <[email protected]>
Louddy
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 15, 2024
This if @fgdorais's patch for leanprover-community/batteries#579. Co-authored-by: F. G. Dorais <[email protected]> Co-authored-by: Scott Morrison <[email protected]>
uniwuni
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 19, 2024
This if @fgdorais's patch for leanprover-community/batteries#579. Co-authored-by: F. G. Dorais <[email protected]> Co-authored-by: Scott Morrison <[email protected]>
callesonne
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 22, 2024
This if @fgdorais's patch for leanprover-community/batteries#579. Co-authored-by: F. G. Dorais <[email protected]> Co-authored-by: Scott Morrison <[email protected]>
github-merge-queue bot
pushed a commit
to leanprover/lean4
that referenced
this pull request
Sep 18, 2024
This incorporates contributions from @eric-wieser in leanprover-community/mathlib4#15952 and @fgdorais in leanprover-community/batteries#579
github-merge-queue bot
pushed a commit
to leanprover/lean4
that referenced
this pull request
Sep 18, 2024
This incorporates contributions from @eric-wieser in leanprover-community/mathlib4#15952 and @fgdorais in leanprover-community/batteries#579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List.mergethe merge step from merge sort (without any ordering assumptions). This will be useful to streamline and optimizeac_rfl.Note that
List.mergeexists in Mathlib but the Mathlib implementation is not tail recursive and it uses a decidable relation instead of aBoolrelation. A Mathlib adaptation PR is in progress: https://github.com/leanprover-community/mathlib4/tree/fgdorais-patch-list-merge