Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: interactions between List.map and sorting lists #15952

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: interactions between List.map and sorting lists #15952

wants to merge 5 commits into from

Conversation

eric-wieser
Copy link
Member

If the function preserves the relation on the list, then the sorting algorithms are unaffected.

Open in Gitpod

@eric-wieser eric-wieser added the t-data Data (lists, quotients, numbers, etc) label Aug 18, 2024
@eric-wieser eric-wieser requested a review from digama0 August 18, 2024 23:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 18, 2024 •
edited
Loading

PR summary e8142f6c98

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ length_insertionSort
+ map_insertionSort
+ map_merge
+ map_mergeSort
+ map_orderedInsert
+ map_sort
+ map_split
+ mem_insertionSort
+ mem_mergeSort
+ mem_split_iff

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@eric-wieser eric-wieser mentioned this pull request Aug 19, 2024
Open
1 task
YaelDillies
YaelDillies approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

maintainer merge

@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@eric-wieser eric-wieser added the t-order Order theory label Aug 20, 2024
@mattrobball
Copy link
Collaborator

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 20, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 20, 2024
@eric-wieser
feat: interactions between List.map and sorting lists (#15952)
ce99234 
If the function preserves the relation on the list, then the sorting algorithms are unaffected.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 20, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Aug 20, 2024
@eric-wieser
feat: interactions between List.map and sorting lists (#15952)
ddec2bc 
If the function preserves the relation on the list, then the sorting algorithms are unaffected.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 20, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: interactions between List.map and sorting lists [Merged by Bors] - feat: interactions between List.map and sorting lists Aug 20, 2024
@mathlib-bors mathlib-bors bot closed this Aug 20, 2024
@mathlib-bors mathlib-bors bot deleted the eric-wieser/sort-lemmas branch August 20, 2024 22:47
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
@eric-wieser @bjoernkjoshanssen
feat: interactions between List.map and sorting lists (#15952)
0359552 
If the function preserves the relation on the list, then the sorting algorithms are unaffected.
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
@eric-wieser @bjoernkjoshanssen
feat: interactions between List.map and sorting lists (#15952)
03e301b 
If the function preserves the relation on the list, then the sorting algorithms are unaffected.
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
@eric-wieser @bjoernkjoshanssen
feat: interactions between List.map and sorting lists (#15952)
2c1bbf0 
If the function preserves the relation on the list, then the sorting algorithms are unaffected.
@kim-em kim-em mentioned this pull request Sep 18, 2024
Merged
github-merge-queue bot pushed a commit to leanprover/lean4 that referenced this pull request Sep 18, 2024
@kim-em
chore: upstream map_mergeSort (#5377)
f5f44ef 
This incorporates contributions from @eric-wieser in
leanprover-community/mathlib4#15952 and
@fgdorais in leanprover-community/batteries#579
github-merge-queue bot pushed a commit to leanprover/lean4 that referenced this pull request Sep 18, 2024
@kim-em
chore: upstream map_mergeSort (#5377)
30e90a4 
This incorporates contributions from @eric-wieser in
leanprover-community/mathlib4#15952 and
@fgdorais in leanprover-community/batteries#579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

@digama0 digama0 Awaiting requested review from digama0

Assignees
No one assigned
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc) t-order Order theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eric-wieser @mattrobball @YaelDillies