Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat (RingTheory/Binomial) : Standard lemmas for Ring.choose #13071

Closed
wants to merge 9 commits into from

Conversation

ScottCarnahan
Copy link
Collaborator

@ScottCarnahan ScottCarnahan commented May 21, 2024

This PR has basic identities satisfied by general binomial coefficients, together with corresponding lemmas about evaluating Pochhammer polynomials.


Open in Gitpod

@ScottCarnahan ScottCarnahan added awaiting-review awaiting-CI t-algebra Algebra (groups, rings, fields, etc) labels May 21, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 30, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 31, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label May 31, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 29, 2024
Copy link

github-actions bot commented Jun 30, 2024

PR summary c7da75cf94

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ choose_add_smul_choose
+ choose_eq_nat_choose
+ choose_one_right
+ choose_one_right'
+ choose_smul_choose
+ choose_succ_succ
+ choose_zero_ite
+ choose_zero_pos
+ choose_zero_right
+ choose_zero_right'
+ choose_zero_succ
+ descPochhammer_succ_succ_smeval

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 30, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 5, 2024
@ScottCarnahan ScottCarnahan changed the title feat (RingTheory/Binomial) : Standard lemmas for Ring.choose and Ring.multichoose feat (RingTheory/Binomial) : Standard lemmas for Ring.choose Jul 5, 2024
@kim-em
Copy link
Contributor

kim-em commented Jul 15, 2024

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 15, 2024

✌️ ScottCarnahan can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ScottCarnahan
Copy link
Collaborator Author

Thank you for the review!

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jul 15, 2024
This PR has basic identities satisfied by general binomial coefficients, together with corresponding lemmas about evaluating Pochhammer polynomials.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 15, 2024

This PR was included in a batch that was canceled, it will be automatically retried

mathlib-bors bot pushed a commit that referenced this pull request Jul 15, 2024
This PR has basic identities satisfied by general binomial coefficients, together with corresponding lemmas about evaluating Pochhammer polynomials.
mathlib-bors bot pushed a commit that referenced this pull request Jul 15, 2024
This PR has basic identities satisfied by general binomial coefficients, together with corresponding lemmas about evaluating Pochhammer polynomials.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 15, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat (RingTheory/Binomial) : Standard lemmas for Ring.choose [Merged by Bors] - feat (RingTheory/Binomial) : Standard lemmas for Ring.choose Jul 15, 2024
@mathlib-bors mathlib-bors bot closed this Jul 15, 2024
@mathlib-bors mathlib-bors bot deleted the ScottCarnahan/BinomialRing4 branch July 15, 2024 21:07
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants