Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat (RingTheory/Binomial) : Multichoose at negative arguments #13430

Closed
wants to merge 5 commits into from

Conversation

ScottCarnahan
Copy link
Collaborator

This PR adds some lemmas for evaluating Pochhammer polynomials and the multichoose function at negative arguments. This is preparation for identities involving generalized binomial coefficients.


Open in Gitpod

@kim-em kim-em added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jul 1, 2024
Copy link

github-actions bot commented Jul 1, 2024

PR summary 1e6d7c9d85

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ multichoose_neg_add
+ multichoose_neg_of_lt
+ multichoose_neg_self
+ multichoose_neg_succ
+ multichoose_succ_neg_natCast
+ smeval_ascPochhammer_int_ofNat
+ smeval_ascPochhammer_nat_cast
+ smeval_ascPochhammer_neg_add
+ smeval_ascPochhammer_neg_of_lt
+ smeval_ascPochhammer_self_neg
+ smeval_ascPochhammer_succ_neg
+ smeval_neg_nat

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@ScottCarnahan ScottCarnahan added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 1, 2024
ScottCarnahan added a commit that referenced this pull request Jul 1, 2024
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

@kim-em
Copy link
Contributor

kim-em commented Jul 4, 2024

If you can make Ruben and my final suggested changes, this looks good. Apologies this took so long!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 4, 2024

✌️ ScottCarnahan can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ScottCarnahan
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jul 5, 2024
This PR adds some lemmas for evaluating Pochhammer polynomials and the multichoose function at negative arguments.  This is preparation for identities involving generalized binomial coefficients.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 5, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat (RingTheory/Binomial) : Multichoose at negative arguments [Merged by Bors] - feat (RingTheory/Binomial) : Multichoose at negative arguments Jul 5, 2024
@mathlib-bors mathlib-bors bot closed this Jul 5, 2024
@mathlib-bors mathlib-bors bot deleted the ScottCarnahan/Multichoose_neg branch July 5, 2024 03:30
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants