Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(Topology/Category): add CompHausLike.EffectiveEpi #13907

Closed
wants to merge 10 commits into from

Conversation

dagurtomas
Copy link
Collaborator

@dagurtomas dagurtomas commented Jun 17, 2024

This is the first part of the refactor of CompHaus and friends (adding the new API which will eventually be used to redefine the categories of compact Hausdorff spaces, see #12930)


Open in Gitpod

Copy link

github-actions bot commented Jun 17, 2024

PR summary 1dea00f973

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Topology.Category.CompHausLike.EffectiveEpi 811

Declarations diff

+ effectiveEpiStruct
+ preregular

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 2, 2024
@dagurtomas dagurtomas removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 2, 2024
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor comment

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 4, 2024

✌️ dagurtomas can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@dagurtomas
Copy link
Collaborator Author

Thanks!

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jul 4, 2024
This is the first part of the refactor of CompHaus and friends (adding the new API which will eventually be used to redefine the categories of compact Hausdorff spaces, see #12930)
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 4, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(Topology/Category): add CompHausLike.EffectiveEpi [Merged by Bors] - refactor(Topology/Category): add CompHausLike.EffectiveEpi Jul 4, 2024
@mathlib-bors mathlib-bors bot closed this Jul 4, 2024
@mathlib-bors mathlib-bors bot deleted the dagur/AddCompHausLikeEffectiveEpi branch July 4, 2024 14:02
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-category-theory Category theory t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants