-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - refactor(Topology/Category): refactor CompHaus.Basic #13908
Conversation
PR summary 77b5a55be6
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.Topology.Category.CompHaus.Basic | 1288 | 1287 | -1 (-0.08%) |
Mathlib.Topology.Category.Profinite.Basic | 1296 | 1295 | -1 (-0.08%) |
Mathlib.Topology.Category.Compactum | 1301 | 1300 | -1 (-0.08%) |
Mathlib.Topology.Category.Stonean.Basic | 1315 | 1314 | -1 (-0.08%) |
Import changes for all files
Files | Import difference |
---|---|
13 filesMathlib.Topology.Category.Stonean.Adjunctions Mathlib.Topology.Category.Profinite.CofilteredLimit Mathlib.Topology.Category.Profinite.AsLimit Mathlib.Topology.Category.CompHaus.Basic Mathlib.Topology.Category.CompHaus.Projective Mathlib.Topology.Category.Profinite.Projective Mathlib.Topology.Category.Profinite.Basic Mathlib.Topology.Category.Compactum Mathlib.Topology.Category.Stonean.Basic Mathlib.Topology.Category.Locale Mathlib.Order.Category.Frm Mathlib.Topology.Category.Profinite.Product Mathlib.Topology.Order.Category.FrameAdjunction |
-1 |
5 filesMathlib.Condensed.Light.Explicit Mathlib.Condensed.Light.TopComparison Mathlib.Condensed.Light.Module Mathlib.Condensed.Light.Discrete Mathlib.Condensed.Epi |
1 |
Declarations diff
+ instance : HasProp (fun _ ↦ True) X := ⟨trivial⟩
- CompHaus
- CompHaus.forget_reflectsIsomorphisms
- category
- coe_of
- coe_toTop
- compHausToTop
- concreteCategory
- instance (X : CompHaus) : CompactSpace (compHausToTop.obj X)
- instance (X : CompHaus) : T2Space (compHausToTop.obj X)
- instance (X : CompHaus.{u}) : CompactSpace ((forget CompHaus).obj X)
- instance (X : CompHaus.{u}) : T2Space ((forget CompHaus).obj X)
- instance (X : CompHaus.{u}) : TopologicalSpace ((forget CompHaus).obj X)
- instance : compHausToTop.Faithful
- instance : compHausToTop.Full
- isClosedMap
- isIso_of_bijective
- isoEquivHomeo
- isoOfBijective
- isoOfHomeo
- mono_iff_injective
- of
--++--+ homeoOfIso
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
This PR/issue depends on: |
Thanks! bors d+ |
✌️ dagurtomas can now approve this pull request. To approve and merge a pull request, simply reply with |
bors merge |
This PR refactors the file `CompHaus.Basic` in terms of the new `CompHausLike` API. Other files are touched only to fix errors created by this refactor, they will be refactored later (in particular, the API for explicit limits will be mostly removed in favour of the general API for explicit limits in `CompHausLike`, see #12930).
Build failed (retrying...): |
This PR refactors the file `CompHaus.Basic` in terms of the new `CompHausLike` API. Other files are touched only to fix errors created by this refactor, they will be refactored later (in particular, the API for explicit limits will be mostly removed in favour of the general API for explicit limits in `CompHausLike`, see #12930).
Build failed (retrying...): |
This PR refactors the file `CompHaus.Basic` in terms of the new `CompHausLike` API. Other files are touched only to fix errors created by this refactor, they will be refactored later (in particular, the API for explicit limits will be mostly removed in favour of the general API for explicit limits in `CompHausLike`, see #12930).
Build failed: |
bors merge |
This PR refactors the file `CompHaus.Basic` in terms of the new `CompHausLike` API. Other files are touched only to fix errors created by this refactor, they will be refactored later (in particular, the API for explicit limits will be mostly removed in favour of the general API for explicit limits in `CompHausLike`, see #12930).
Pull request successfully merged into master. Build succeeded: |
This PR refactors the file
CompHaus.Basic
in terms of the newCompHausLike
API. Other files are touched only to fix errors created by this refactor, they will be refactored later (in particular, the API for explicit limits will be mostly removed in favour of the general API for explicit limits inCompHausLike
, see #12930).