Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(Topology/Category): refactor CompHaus.Basic #13908

Closed
wants to merge 12 commits into from

Conversation

dagurtomas
Copy link
Collaborator

@dagurtomas dagurtomas commented Jun 17, 2024

This PR refactors the file CompHaus.Basic in terms of the new CompHausLike API. Other files are touched only to fix errors created by this refactor, they will be refactored later (in particular, the API for explicit limits will be mostly removed in favour of the general API for explicit limits in CompHausLike, see #12930).


Open in Gitpod

Copy link

github-actions bot commented Jun 17, 2024

PR summary 77b5a55be6

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Topology.Category.CompHaus.Basic 1288 1287 -1 (-0.08%)
Mathlib.Topology.Category.Profinite.Basic 1296 1295 -1 (-0.08%)
Mathlib.Topology.Category.Compactum 1301 1300 -1 (-0.08%)
Mathlib.Topology.Category.Stonean.Basic 1315 1314 -1 (-0.08%)
Import changes for all files
Files Import difference
13 files Mathlib.Topology.Category.Stonean.Adjunctions Mathlib.Topology.Category.Profinite.CofilteredLimit Mathlib.Topology.Category.Profinite.AsLimit Mathlib.Topology.Category.CompHaus.Basic Mathlib.Topology.Category.CompHaus.Projective Mathlib.Topology.Category.Profinite.Projective Mathlib.Topology.Category.Profinite.Basic Mathlib.Topology.Category.Compactum Mathlib.Topology.Category.Stonean.Basic Mathlib.Topology.Category.Locale Mathlib.Order.Category.Frm Mathlib.Topology.Category.Profinite.Product Mathlib.Topology.Order.Category.FrameAdjunction
-1
5 files Mathlib.Condensed.Light.Explicit Mathlib.Condensed.Light.TopComparison Mathlib.Condensed.Light.Module Mathlib.Condensed.Light.Discrete Mathlib.Condensed.Epi
1

Declarations diff

+ instance : HasProp (fun _ ↦ True) X := ⟨trivial⟩
- CompHaus
- CompHaus.forget_reflectsIsomorphisms
- category
- coe_of
- coe_toTop
- compHausToTop
- concreteCategory
- instance (X : CompHaus) : CompactSpace (compHausToTop.obj X)
- instance (X : CompHaus) : T2Space (compHausToTop.obj X)
- instance (X : CompHaus.{u}) : CompactSpace ((forget CompHaus).obj X)
- instance (X : CompHaus.{u}) : T2Space ((forget CompHaus).obj X)
- instance (X : CompHaus.{u}) : TopologicalSpace ((forget CompHaus).obj X)
- instance : compHausToTop.Faithful
- instance : compHausToTop.Full
- isClosedMap
- isIso_of_bijective
- isoEquivHomeo
- isoOfBijective
- isoOfHomeo
- mono_iff_injective
- of
--++--+ homeoOfIso

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jun 17, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 2, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 4, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 5, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 6, 2024
@riccardobrasca
Copy link
Member

Thanks!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 16, 2024

✌️ dagurtomas can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@dagurtomas
Copy link
Collaborator Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jul 16, 2024
This PR refactors the file `CompHaus.Basic` in terms of the new `CompHausLike` API. Other files are touched only to fix errors created by this refactor, they will be refactored later (in particular, the API for explicit limits will be mostly removed in favour of the general API for explicit limits in `CompHausLike`, see #12930).
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 16, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jul 16, 2024
This PR refactors the file `CompHaus.Basic` in terms of the new `CompHausLike` API. Other files are touched only to fix errors created by this refactor, they will be refactored later (in particular, the API for explicit limits will be mostly removed in favour of the general API for explicit limits in `CompHausLike`, see #12930).
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 16, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jul 16, 2024
This PR refactors the file `CompHaus.Basic` in terms of the new `CompHausLike` API. Other files are touched only to fix errors created by this refactor, they will be refactored later (in particular, the API for explicit limits will be mostly removed in favour of the general API for explicit limits in `CompHausLike`, see #12930).
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 16, 2024

Build failed:

@dagurtomas
Copy link
Collaborator Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jul 16, 2024
This PR refactors the file `CompHaus.Basic` in terms of the new `CompHausLike` API. Other files are touched only to fix errors created by this refactor, they will be refactored later (in particular, the API for explicit limits will be mostly removed in favour of the general API for explicit limits in `CompHausLike`, see #12930).
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(Topology/Category): refactor CompHaus.Basic [Merged by Bors] - refactor(Topology/Category): refactor CompHaus.Basic Jul 16, 2024
@mathlib-bors mathlib-bors bot closed this Jul 16, 2024
@mathlib-bors mathlib-bors bot deleted the dagur/RefactorCompHausBasic branch July 16, 2024 22:33
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-category-theory Category theory t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants