-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: delay imports of Star #14219
Conversation
PR summary a9a992889b
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.Algebra.Star.Basic | 493 | 394 | -99 (-20.08%) |
Mathlib.Algebra.Module.LinearMap.Basic | 515 | 498 | -17 (-3.30%) |
Mathlib.Algebra.Module.Equiv | 518 | 501 | -17 (-3.28%) |
Mathlib.Algebra.Algebra.Defs | 612 | 609 | -3 (-0.49%) |
Mathlib.Analysis.Seminorm | 1147 | 1143 | -4 (-0.35%) |
Mathlib.Algebra.RingQuot | 874 | 871 | -3 (-0.34%) |
Mathlib.Topology.Algebra.Module.Basic | 964 | 961 | -3 (-0.31%) |
Mathlib.Algebra.Algebra.Equiv | 731 | 729 | -2 (-0.27%) |
Mathlib.Analysis.Normed.Order.UpperLower | 1162 | 1159 | -3 (-0.26%) |
Mathlib.Analysis.Normed.Group.Quotient | 1169 | 1166 | -3 (-0.26%) |
Mathlib.Data.Real.Sqrt | 1033 | 1031 | -2 (-0.19%) |
Mathlib.Analysis.SumOverResidueClass | 1123 | 1121 | -2 (-0.18%) |
Declarations diff
+ Real.instStarOrderedRing
- instance : StarOrderedRing ℝ
You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>
Have you considered going the other way? It seems like we could have a Also please keep the imports sorted |
We should do that too! :-) |
I'm assuming the rule is just alphabetic? I hadn't realised we were doing this. |
(The motivation here was being annoyed at encountering these imports when doing a minimization.) |
bors delegate+ |
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
bors merge |
bors r- bors d+ |
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
Canceled. |
Co-authored-by: Eric Wieser <[email protected]>
Co-authored-by: Eric Wieser <[email protected]>
Co-authored-by: Eric Wieser <[email protected]>
bors merge |
Pull request successfully merged into master. Build succeeded: |
No description provided.