Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: delay imports of Star #14219

Closed
wants to merge 7 commits into from
Closed

Conversation

kim-em
Copy link
Contributor

@kim-em kim-em commented Jun 28, 2024

No description provided.

Copy link

github-actions bot commented Jun 28, 2024

PR summary a9a992889b

Import changes

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Star.Basic 493 394 -99 (-20.08%)
Mathlib.Algebra.Module.LinearMap.Basic 515 498 -17 (-3.30%)
Mathlib.Algebra.Module.Equiv 518 501 -17 (-3.28%)
Mathlib.Algebra.Algebra.Defs 612 609 -3 (-0.49%)
Mathlib.Analysis.Seminorm 1147 1143 -4 (-0.35%)
Mathlib.Algebra.RingQuot 874 871 -3 (-0.34%)
Mathlib.Topology.Algebra.Module.Basic 964 961 -3 (-0.31%)
Mathlib.Algebra.Algebra.Equiv 731 729 -2 (-0.27%)
Mathlib.Analysis.Normed.Order.UpperLower 1162 1159 -3 (-0.26%)
Mathlib.Analysis.Normed.Group.Quotient 1169 1166 -3 (-0.26%)
Mathlib.Data.Real.Sqrt 1033 1031 -2 (-0.19%)
Mathlib.Analysis.SumOverResidueClass 1123 1121 -2 (-0.18%)

Declarations diff

+ Real.instStarOrderedRing
- instance : StarOrderedRing ℝ

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@Ruben-VandeVelde
Copy link
Collaborator

Have you considered going the other way? It seems like we could have a Star.Defs file could be very light-weight.

Also please keep the imports sorted

@kim-em
Copy link
Contributor Author

kim-em commented Jun 28, 2024

Have you considered going the other way? It seems like we could have a Star.Defs file could be very light-weight.

We should do that too! :-)

@kim-em
Copy link
Contributor Author

kim-em commented Jun 28, 2024

Also please keep the imports sorted

I'm assuming the rule is just alphabetic? I hadn't realised we were doing this.

@kim-em
Copy link
Contributor Author

kim-em commented Jun 28, 2024

(The motivation here was being annoyed at encountering these imports when doing a minimization.)

@mattrobball
Copy link
Collaborator

bors delegate+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 28, 2024

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@kim-em
Copy link
Contributor Author

kim-em commented Jun 28, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jun 28, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 28, 2024
@eric-wieser
Copy link
Member

bors r-

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 28, 2024

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 28, 2024

Canceled.

@kim-em
Copy link
Contributor Author

kim-em commented Jun 28, 2024

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jun 28, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 28, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: delay imports of Star [Merged by Bors] - chore: delay imports of Star Jun 28, 2024
@mathlib-bors mathlib-bors bot closed this Jun 28, 2024
@mathlib-bors mathlib-bors bot deleted the star_linear branch June 28, 2024 13:53
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants