-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: move 300 lines off Combinatorics/SimpleGraph/Connectivity #14647
Conversation
PR summary 29dcdf82d7Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> |
@adomani surely the import summary is wrong? This PR is supposed to significantly change imports |
I wonder whether this is another situation where using "number of transitive imports" is not really the metric that we should be using. In this PR, as far as I understand, you
The import changes does tell you that
In conclusion, I think that the import tool is working as it was programmed to work. I still agree that this is probably not the measure that we should necessarily look at to make import-based decisions. |
I feel that a more reasonable measure would be to find the number of covering relations among imports, or maybe the average number of covering relations per vertex. |
bors merge |
Build failed (retrying...): |
bors r- |
Canceled. |
Unclosed section. bors delegate+ |
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
CI is virtually green (only environment linting remains, which this PR didn't touch), so |
Pull request successfully merged into master. Build succeeded: |
Move material about walks as subgraphs and walk-counting to separate files.
Mostly import-directed; I'm not a graph theorist - please comment if this split doesn't make sense!
(Also, feel free to suggest if the new module docstring should be extended!)