Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: move 300 lines off Combinatorics/SimpleGraph/Connectivity #14647

Closed
wants to merge 4 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Jul 11, 2024

Move material about walks as subgraphs and walk-counting to separate files.

Mostly import-directed; I'm not a graph theorist - please comment if this split doesn't make sense!


(Also, feel free to suggest if the new module docstring should be extended!)

Open in Gitpod

@grunweg grunweg added RFC Request for comment t-combinatorics Combinatorics tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Jul 11, 2024
Copy link

github-actions bot commented Jul 11, 2024

PR summary 29dcdf82d7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
4 files Mathlib.Combinatorics.SimpleGraph.StronglyRegular Mathlib.Combinatorics.SimpleGraph.LapMatrix Mathlib.Combinatorics.SimpleGraph.AdjMatrix Mathlib.Combinatorics.SimpleGraph.Matching
1
Mathlib.Combinatorics.SimpleGraph.Connectivity.WalkCounting 520

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@YaelDillies
Copy link
Collaborator

@adomani surely the import summary is wrong? This PR is supposed to significantly change imports

@adomani
Copy link
Collaborator

adomani commented Jul 11, 2024

I wonder whether this is another situation where using "number of transitive imports" is not really the metric that we should be using. In this PR, as far as I understand, you

  • added a new leaf and
  • replaced a few edges into the file from which you extracted the new leaf to point to the new leaf.

The import changes does tell you that

  • the new leaf WalkCounting now has 515 transitive imports (it did not exist earlier, so far so good);
  • AdjMatrix and the files that import it gained one transitive import, since they now point to the new leaf on their way to then having the same imports.

In conclusion, I think that the import tool is working as it was programmed to work. I still agree that this is probably not the measure that we should necessarily look at to make import-based decisions.

@adomani
Copy link
Collaborator

adomani commented Jul 11, 2024

I feel that a more reasonable measure would be to find the number of covering relations among imports, or maybe the average number of covering relations per vertex.

@kim-em
Copy link
Contributor

kim-em commented Jul 15, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 15, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 15, 2024
)

Move material about walks as subgraphs and walk-counting to separate files.

Mostly import-directed; I'm not a graph theorist - please comment if this split doesn't make sense!
(Also, feel free to suggest if the new module docstring should be extended!)
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 15, 2024

Build failed (retrying...):

@mattrobball
Copy link
Collaborator

bors r-

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 15, 2024

Canceled.

@mattrobball
Copy link
Collaborator

Unclosed section.

bors delegate+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 15, 2024

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@grunweg
Copy link
Collaborator Author

grunweg commented Jul 16, 2024

CI is virtually green (only environment linting remains, which this PR didn't touch), so
bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jul 16, 2024
)

Move material about walks as subgraphs and walk-counting to separate files.

Mostly import-directed; I'm not a graph theorist - please comment if this split doesn't make sense!
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: move 300 lines off Combinatorics/SimpleGraph/Connectivity [Merged by Bors] - chore: move 300 lines off Combinatorics/SimpleGraph/Connectivity Jul 16, 2024
@mathlib-bors mathlib-bors bot closed this Jul 16, 2024
@mathlib-bors mathlib-bors bot deleted the MR-split-combinatorics-graphs branch July 16, 2024 09:31
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. RFC Request for comment t-combinatorics Combinatorics tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants