fix(gossipsub): fix inconsistent publish to floodsub peers #5904
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
publish broadcasted to all floodsub peers regardless of their topics
Notes & open questions
publish
broadcasted to all floodsub peers regardless of their topics whenconfig.flood_publish = false
.config.flood_publish = true
publishes to subscribed peers only.rust-libp2p floodsub publishes message to subscribed peers only (code).
go-libp2p-pubsub gossipsub publishes message to subscribed peers only (code).
This PR reduces messages count, while #5908 increases it, so I thought they can be reviewed independently.
Change checklist