Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gossipsub): fix inconsistent publish to floodsub peers #5904

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Mar 4, 2025

Description

publish broadcasted to all floodsub peers regardless of their topics

Notes & open questions

publish broadcasted to all floodsub peers regardless of their topics when config.flood_publish = false.
config.flood_publish = true publishes to subscribed peers only.
rust-libp2p floodsub publishes message to subscribed peers only (code).
go-libp2p-pubsub gossipsub publishes message to subscribed peers only (code).
This PR reduces messages count, while #5908 increases it, so I thought they can be reviewed independently.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

publish broadcasted to all floodsub peers regardless of their topics
@dariusc93 dariusc93 requested a review from jxs March 4, 2025 11:22
@dariusc93 dariusc93 changed the title fix inconsistent publish to floodsub peers fix(gossipsub): fix inconsistent publish to floodsub peers Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant