fix(gossipsub): forward to floodsub peers #5908
Merged
+10
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
messages weren't forwarded to floodsub peers
Notes & open questions
rust-libp2p gossipsub
forward_msg
sends message to explicit and mesh peers only,which doesn't include floodsub peers.
go-libp2p-pubsub gossipsub forwards messages to explicit and mesh peers too,
as well as floodsub peers (code)
(call stack:
PubSub.handleIncomingRPC
,PubSub.pushMsg
,PubSub.publishMessage
,GossipSubRouter.Publish
).Change checklist