Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return types to silence Symfony 6.3 deprecations #1514

Merged
merged 1 commit into from
May 16, 2023
Merged

Add return types to silence Symfony 6.3 deprecations #1514

merged 1 commit into from
May 16, 2023

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented May 15, 2023

Q A
Branch? 2.x
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets N/A
License MIT
Doc N/A

Symfony 6.3 added a number of return types to the framework. This PR should cover all the ones that popped up when beta testing an application.

Because all affected classes are non-final/internal, doc block annotations are used.

@coveralls
Copy link

coveralls commented May 15, 2023 •
edited
Loading

Coverage Status

Coverage: 79.901%. Remained the same when pulling 8b23f88 on mbabker:silence-symfony-6.3-return-type-deprecations into 9cc3fe6 on liip:2.x.

dbu
dbu requested changes May 15, 2023
View reviewed changes
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. i would prefer to add actual return type declarations as the compiler passes are not extension points.

@mbabker mbabker force-pushed the silence-symfony-6.3-return-type-deprecations branch from 5c22a35 to 8b23f88 Compare May 15, 2023 16:04
@mbabker
Copy link
Contributor Author

mbabker commented May 15, 2023

thanks. i would prefer to add actual return type declarations as the compiler passes are not extension points.

Updated

dbu
dbu approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks a lot!

@dbu dbu merged commit da26d5e into liip:2.x May 16, 2023
@dbu
Copy link
Member

dbu commented May 16, 2023

https://github.com/liip/LiipImagineBundle/releases/tag/2.11.0

@mbabker mbabker deleted the silence-symfony-6.3-return-type-deprecations branch May 16, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbabker @coveralls @dbu