Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return types to silence Symfony 6.3 deprecations #1514

Merged
merged 1 commit into from
May 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DependencyInjection/Compiler/AssetsVersionCompilerPass.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
*/
class AssetsVersionCompilerPass extends AbstractCompilerPass
{
public function process(ContainerBuilder $container)
public function process(ContainerBuilder $container): void
{
if (!class_exists(StaticVersionStrategy::class)
// this application has no asset version configured
Expand Down
5 changes: 1 addition & 4 deletions DependencyInjection/Compiler/DriverCompilerPass.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,7 @@
*/
class DriverCompilerPass extends AbstractCompilerPass
{
/**
* {@inheritdoc}
*/
public function process(ContainerBuilder $container)
public function process(ContainerBuilder $container): void
{
$liipImagineDriver = $container->getParameter('liip_imagine.driver_service');

Expand Down
5 changes: 1 addition & 4 deletions DependencyInjection/Compiler/FiltersCompilerPass.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,7 @@

class FiltersCompilerPass extends AbstractCompilerPass
{
/**
* {@inheritdoc}
*/
public function process(ContainerBuilder $container)
public function process(ContainerBuilder $container): void
{
$tags = $container->findTaggedServiceIds('liip_imagine.filter.loader');

Expand Down
5 changes: 1 addition & 4 deletions DependencyInjection/Compiler/LoadersCompilerPass.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,7 @@

class LoadersCompilerPass extends AbstractCompilerPass
{
/**
* {@inheritdoc}
*/
public function process(ContainerBuilder $container)
public function process(ContainerBuilder $container): void
{
$tags = $container->findTaggedServiceIds('liip_imagine.binary.loader');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@
*/
final class MaybeSetMimeServicesAsAliasesCompilerPass extends AbstractCompilerPass
{
/**
* {@inheritdoc}
*/
public function process(ContainerBuilder $container): void
{
if ($container->hasDefinition('mime_types')) {
Expand Down
3 changes: 0 additions & 3 deletions DependencyInjection/Compiler/MetadataReaderCompilerPass.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@ class MetadataReaderCompilerPass extends AbstractCompilerPass
*/
private static $metadataReaderExifClass = 'Imagine\Image\Metadata\ExifMetadataReader';

/**
* {@inheritdoc}
*/
public function process(ContainerBuilder $container): void
{
if (!$this->isExifExtensionLoaded() && $this->isExifMetadataReaderSet($container)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
*/
class NonFunctionalFilterExceptionPass implements CompilerPassInterface
{
public function process(ContainerBuilder $container)
public function process(ContainerBuilder $container): void
{
$canFiltersStillFunction = $container->hasParameter('kernel.root_dir');
$throwWarning = function (string $filterName) use ($canFiltersStillFunction) {
Expand Down
5 changes: 1 addition & 4 deletions DependencyInjection/Compiler/PostProcessorsCompilerPass.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,7 @@
*/
class PostProcessorsCompilerPass extends AbstractCompilerPass
{
/**
* {@inheritdoc}
*/
public function process(ContainerBuilder $container)
public function process(ContainerBuilder $container): void
{
$tags = $container->findTaggedServiceIds('liip_imagine.filter.post_processor');

Expand Down
5 changes: 1 addition & 4 deletions DependencyInjection/Compiler/ResolversCompilerPass.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,7 @@

class ResolversCompilerPass extends AbstractCompilerPass
{
/**
* {@inheritdoc}
*/
public function process(ContainerBuilder $container)
public function process(ContainerBuilder $container): void
{
$tags = $container->findTaggedServiceIds('liip_imagine.cache.resolver');

Expand Down
2 changes: 1 addition & 1 deletion DependencyInjection/LiipImagineExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public function getConfiguration(array $config, ContainerBuilder $container): ?C
/**
* @see \Symfony\Component\DependencyInjection\Extension.ExtensionInterface::load()
*/
public function load(array $configs, ContainerBuilder $container)
public function load(array $configs, ContainerBuilder $container): void
{
$config = $this->processConfiguration(
$this->getConfiguration($configs, $container),
Expand Down
5 changes: 1 addition & 4 deletions LiipImagineBundle.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,7 @@

class LiipImagineBundle extends Bundle
{
/**
* {@inheritdoc}
*/
public function build(ContainerBuilder $container)
public function build(ContainerBuilder $container): void
{
parent::build($container);

Expand Down