Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The helm schema should allow only a memory or only a cpu setting in limits for defaultResources (currently it requires both/neither) #3720

Closed
theosanderson opened this issue Feb 19, 2025 · 0 comments · Fixed by #3723
Closed

The helm schema should allow only a memory or only a cpu setting in limits for defaultResources (currently it requires both/neither) #3720

theosanderson opened this issue Feb 19, 2025 · 0 comments · Fixed by #3723

Comments

@theosanderson
Copy link
Member

The schema should allow only a memory or only a cpu setting in limits for defaultResources (currently it doesn't, and that may apply more broadly)

          huh - this isn't allowed - seems like a bug in the schema - but your original `1000m` seems good for now

Originally posted by @theosanderson in #3715 (comment)
@theosanderson theosanderson mentioned this issue Feb 19, 2025
Open
@theosanderson theosanderson changed the title The helm schema should allow only a memory or only a cpu setting in limits for defaultResources The helm schema should allow only a memory or only a cpu setting in limits for defaultResources (currently it requires both/neither) Feb 19, 2025
theosanderson added a commit that referenced this issue Feb 20, 2025
@theosanderson
The helm schema should allow only a memory or only a cpu setting …
fcf4037 
…in `limits` for `defaultResources`

Fixes #3720

Modify the helm schema to allow only a `memory` or only a `cpu` setting in `limits` for `defaultResources`.

* Make `memory` property in `limits` optional.
* Make `cpu` property in `limits` optional.
* Remove the requirement for both `memory` and `cpu` settings in `limits`.
* Remove the requirement for both `requests` and `limits` in `defaultResources`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/loculus-project/loculus/issues/3720?shareId=XXXX-XXXX-XXXX-XXXX).
@theosanderson theosanderson mentioned this issue Feb 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deployment): make memory / cpu optional settings in Helm schema loculus-project/loculus
1 participant
@theosanderson