-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deployment): reduce cpu requests to realistic requirements allowing more previews #3715
base: main
Are you sure you want to change the base?
Conversation
…wing more previews
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're currently limited in Loculus preview deployments because of having too much CPU requests. The requests are way higher than actual utilization, which means we could actually have more previews without any issues - if we simply reduced overly high CPU requests.
This wasn't the case earlier today when I had to remove previews - my preview was running but various components dying due to OOM issues. I'm not saying that's always true - I presume you are seeing an issue that has prompted this - but presumably we're relatively balanced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure (but in my specific case it was memory that was crashing it - I could see it in argoCD, so both were likely limiting)
@@ -1763,6 +1763,5 @@ defaultResources: | |||
cpu: "20m" | |||
limits: | |||
memory: "1Gi" | |||
cpu: "20m" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh - this isn't allowed - seems like a bug in the schema - but your original 1000m
seems good for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to do both or neithe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like a bug in the schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're currently limited in Loculus preview deployments because of having too much CPU requests. The requests are way higher than actual utilization, which means we could actually have more previews without any issues - if we simply reduced overly high CPU requests.
This PR does that - in particular ingest and databases asked for more CPU than necessary.