-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deployment): reduce cpu requests to realistic requirements allowing more previews #3715
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,7 +26,7 @@ spec: | |
resources: | ||
requests: | ||
memory: "200Mi" | ||
cpu: "250m" | ||
cpu: "50m" | ||
limits: | ||
memory: "2Gi" | ||
ports: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1719,7 +1719,7 @@ resources: | |
ingest: | ||
requests: | ||
memory: "1Gi" | ||
cpu: "200m" | ||
cpu: "20m" | ||
theosanderson marked this conversation as resolved.
Show resolved
Hide resolved
|
||
limits: | ||
cpu: "200m" | ||
memory: "10Gi" | ||
|
@@ -1738,7 +1738,7 @@ resources: | |
lapis: | ||
requests: | ||
memory: "220Mi" | ||
cpu: "30m" | ||
cpu: "20m" | ||
limits: | ||
memory: "5Gi" | ||
silo-preprocessing: | ||
|
@@ -1749,7 +1749,7 @@ resources: | |
backend: | ||
requests: | ||
memory: "640Mi" | ||
cpu: "250m" | ||
cpu: "150m" | ||
limits: | ||
memory: "3Gi" # Backend requires at least 635741K of memory | ||
preprocessing: | ||
|
@@ -1763,6 +1763,5 @@ defaultResources: | |
cpu: "20m" | ||
limits: | ||
memory: "1Gi" | ||
cpu: "20m" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. huh - this isn't allowed - seems like a bug in the schema - but your original There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You have to do both or neithe? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
ingest: | ||
ncbiGatewayUrl: null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasn't the case earlier today when I had to remove previews - my preview was running but various components dying due to OOM issues. I'm not saying that's always true - I presume you are seeing an issue that has prompted this - but presumably we're relatively balanced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, there were a bunch of events saying "failed scheduling due to insufficient CPU" throughout the day and we were above 93% for CPU utilization earlier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://grafana.loculus.org/explore?schemaVersion=1&panes=%7B%22tnw%22:%7B%22datasource%22:%22P8E80F9AEF21F6940%22,%22queries%22:%5B%7B%22refId%22:%22A%22,%22expr%22:%22%7Bkubernetes_events%3D%5C%221%5C%22%7D%20%7C%3D%20%60Insufficient%20cpu%60%22,%22queryType%22:%22range%22,%22datasource%22:%7B%22type%22:%22loki%22,%22uid%22:%22P8E80F9AEF21F6940%22%7D,%22editorMode%22:%22builder%22%7D%5D,%22range%22:%7B%22from%22:%22now-24h%22,%22to%22:%22now%22%7D%7D%7D&orgId=1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure (but in my specific case it was memory that was crashing it - I could see it in argoCD, so both were likely limiting)