Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file_attribute for file uploads. #428

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Add file_attribute for file uploads. #428

merged 2 commits into from
Jul 20, 2020

Conversation

wout
Copy link
Contributor

@wout wout commented Jul 18, 2020

This PR adds file uploads as @paulcsmith suggested initially in luckyframework/lucky#1195. That is, with a file_attribute macro rather than through regular attributes.

@wout wout mentioned this pull request Jul 18, 2020
Closed
7 tasks
paulcsmith
paulcsmith approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Can you ping me when you have a Lucky PR open that adds Avram::Uploadable to Lucky?

@paulcsmith paulcsmith merged commit 1691380 into luckyframework:master Jul 20, 2020
@wout
Copy link
Contributor Author

wout commented Jul 21, 2020

I'll have to refresh my memory, it's been a while...

@paulcsmith
Copy link
Member

I believe that you'd need to include Avram::Uploadable to Lucky::UploadedFile https://github.com/luckyframework/lucky/blob/master/src/lucky/uploaded_file.cr. Then I think it should "just work" but you never know :P

@wout
Copy link
Contributor Author

wout commented Jul 21, 2020 •
edited
Loading

Right, that was it. Thanks! 😄

I'll submit a PR today, but I think there should be at least a dedicated spec for Lucky::UploadedFile first.

@wout wout mentioned this pull request Jul 21, 2020
Merged
5 tasks
@wout
Copy link
Contributor Author

wout commented Jul 21, 2020 •
edited
Loading

@paulcsmith PR created!

luckyframework/lucky#1222

@oneiros oneiros mentioned this pull request Oct 6, 2020
Closed
@jwoertink jwoertink mentioned this pull request Nov 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcsmith paulcsmith paulcsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wout @paulcsmith