Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update uploaded file to play nice with avram uploadable. #1222

Merged
merged 2 commits into from Jul 25, 2020
Merged

Update uploaded file to play nice with avram uploadable. #1222

merged 2 commits into from Jul 25, 2020

Conversation

wout
Copy link
Contributor

@wout wout commented Jul 21, 2020 •
edited
Loading

Purpose

Adds what's needed to make the new file_attribute in Avram work with Lucky.

luckyframework/avram#428

Description

Specs will fail on CI, but it's tested with the new Avram::Uploadable included and they do pass. 😊️

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@wout wout mentioned this pull request Jul 21, 2020
Merged
paulcsmith
paulcsmith reviewed Jul 23, 2020
View reviewed changes
Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! The specs are failing though so I think the shard needs to be updated to branch: master for avram

@wout
Copy link
Contributor Author

wout commented Jul 24, 2020

@paulcsmith Ok, I wasn't sure about changing dependencies just for the PR.

@paulcsmith
Copy link
Member

Looks great! Thanks @wout

@paulcsmith paulcsmith merged commit 08dd66d into luckyframework:master Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcsmith paulcsmith paulcsmith left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wout @paulcsmith