-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LuckyFlow::Element#value uses property instead of attribute #88
Conversation
@@ -1,7 +1,7 @@ | |||
class LuckyFlow::Element | |||
private getter raw_selector | |||
getter inner_text | |||
delegate text, click, send_keys, displayed?, attribute, to: element | |||
delegate text, click, send_keys, displayed?, attribute, property, to: element |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while attribute
is no longer used in the class, I wasn't sure about removing it from this list since it is technically public API. I can remove it, though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep it in. At least for this next release. We can see about deprecating it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine. Can we have a spec that shows using this just so we can verify it works?
@jwoertink Do you mean a spec testing the lucky_flow/spec/lucky_flow_spec.cr Lines 77 to 90 in 78f895d
|
I was thinking more on the |
The reasoning behind this was laid out here: #86
TLDR: switching to
property
allows us to add support for other browsers in the futureFixes #86