Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LuckyFlow::Element#value uses property instead of attribute #88

Merged
merged 1 commit into from
Jun 8, 2020
Merged

LuckyFlow::Element#value uses property instead of attribute #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lucky_flow/element.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
class LuckyFlow::Element
private getter raw_selector
getter inner_text
delegate text, click, send_keys, displayed?, attribute, to: element
delegate text, click, send_keys, displayed?, attribute, property, to: element
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while attribute is no longer used in the class, I wasn't sure about removing it from this list since it is technically public API. I can remove it, though

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep it in. At least for this next release. We can see about deprecating it later.

delegate session, to: LuckyFlow

def initialize(@raw_selector : String, text @inner_text : String? = nil)
Expand All @@ -14,7 +14,7 @@ class LuckyFlow::Element
end

def value
attribute("value")
property("value")
end

# Set the text of a form field
Expand Down