feat(account): restyle sign in page #1687
Conversation
dargmuesli
force-pushed
the
feat/account/restyle
branch
from
ff17304 to
691a5a9
Compare
|
@huzaifaedhi22 I'll fully review this next week, I've burnt through a bit of my backlog. |
dargmuesli
force-pushed
the
master
branch
2 times, most recently
from
db8592b to
95ec293
Compare
| to?: RouteLocationRaw | ||
| type?: 'button' | 'reset' | 'submit' | ||
| } | ||
|
|
There was a problem hiding this comment.
empty line to be removed
|
|
||
| <AppLink :to="localePath('index')" :is-colored="true"> | ||
| {{ t('imprint') }} | ||
| </AppLink> | ||
|
|
There was a problem hiding this comment.
| <AppLink :to="localePath('index')" :is-colored="true"> | |
| {{ t('imprint') }} | |
| </AppLink> | |
| <AppLink :to="localePath('index')" :is-colored="true"> | |
| {{ t('imprint') }} | |
| </AppLink> |
|
|
||
| <i18n lang="yaml"> | ||
| de: | ||
| terms: Bedingungen |
There was a problem hiding this comment.
| terms: Bedingungen | |
| terms: Nutzungsbedingungen |
| @@ -104,6 +145,7 @@ const rules = { | |||
| password: VALIDATION_PASSWORD(), | |||
| emailAddress: VALIDATION_EMAIL_ADDRESS({ isRequired: true }), | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
empty line to be removed, it's all the vuelidate part
|
|
||
| const legalTerms = computed(() => { | ||
| return ( | ||
| legalTermsQuery.value?.allLegalTerms?.edges |
There was a problem hiding this comment.
What about .nodes instead of .edges? We use nodes in all other places
| </div> | ||
|
|
There was a problem hiding this comment.
unnecessary empty line
| @@ -21,5 +21,5 @@ useHeadDefault({ title }) | |||
| de: | |||
| title: Registrieren | |||
There was a problem hiding this comment.
| title: Registrieren | |
| title: Erstelle ein Konto |
src/gql/generated/graphcache.ts
Outdated
There was a problem hiding this comment.
Master should be merged in to resolve these diffs
huzaifaedhi22
force-pushed
the
feat/account/restyle
branch
from
02166c7 to
9df88a4
Compare
src/app/assets/css/app.css
Outdated
| --critic-string: #e00000; | ||
| --faint-line: #f2f2f2; | ||
| --faint-weak: #f2f2f2; | ||
| --semantic-accent-accent-icon: #12683a; | ||
| --semantic-accent-accent-text: #12683a; |
There was a problem hiding this comment.
Why remove any line here?
| @@ -304,6 +305,15 @@ | |||
| ); | |||
| } | |||
|
|
|||
| @utility vio-line-clamp-2 { | |||
src/app/assets/css/maevsi.css
Outdated
| @@ -0,0 +1,406 @@ | |||
| /* stylelint-disable at-rule-no-deprecated */ | |||
There was a problem hiding this comment.
This file is now called app.css, maevsi.css does not exist anymore.
| 'rounded-sm', | ||
| ...(props.isColored ? ['text-link-dark dark:text-link-bright'] : []), | ||
| 'rounded', | ||
| ...(props.isColored ? ['text-accent-strong dark:text-link-bright'] : []), |
There was a problem hiding this comment.
Does this work? Shouldn't it be
| ...(props.isColored ? ['text-accent-strong dark:text-link-bright'] : []), | |
| ...(props.isColored ? ['text-(--accent-strong= dark:text-link-bright'] : []), |
?
| :is-underlined="true" | ||
| :is-colored="true" |
There was a problem hiding this comment.
| :is-underlined="true" | |
| :is-colored="true" | |
| is-underlined | |
| is-colored |
📚 Description
Started working on aligning the app implementation to our new design.
📝 Checklist